Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python

Posted by Ryan Carson
Ryan Carson
23,287 Points

Feedback on my Python Script? Learning OOP :)

I just converted my function Python script to OOP and I'd love some folk's feedback!

Here's the GitHub Repo: name_palace.

Pull Requests and comments welcome!

Ryan Carson
Ryan Carson
23,287 Points

Kenneth Love, just pinging you. I know you're busy so don't feel obligated to respond though :)

1 Answer

Chris Shaw
Chris Shaw
26,676 Points

Hello again Ryan,

I've put my pull request in.

https://github.com/ryancarson/name_palace/pull/2

I'm not sure about unpacking the class instance variables using __dict__ but it appears to be common practice.

Ryan Carson
Ryan Carson
23,287 Points

Thanks Chris! Fun to hear your feedback and get a PR :)