After word is guessed, the program doesn't break

Question

import random
words = [
    'apple',
    'bannana',
    'oragne',
    'squash',
    'melon',
    'blueberry',
    'raspberry',
    'strawberry'
]
while True:
    start = input("Press enter/return to start, or enter Q to quit")
    if start.lower() == 'q':
        break
secret_word = random.choice(words)
bad_guesses = []
good_guesses = []

while len(bad_guesses) < 7 and len(good_guesses) != len(list(secret_word)):
    for letter in secret_word:
        if letter in good_guesses:
            print(letter, end='')
        else:
            print('_', end='')
    print('')
    print('Strikes: {}/7'.format(len(bad_guesses)))
    print('')

guess = input("Guess a letter: ".lower())

if len(guess) != 1:
        print("You can only guess a signle letter!")
        continue
    elif guess in bad_guesses or guess in good_guesses:
        print("You've already guessed that letter!")
        continue
    elif not guess.isalpha():
        print("You can only guess letter!")
        continue
    if guess in secret_word:
        good_guesses.append(guess)
        if len(good_guesses) == len(list(secret_word)):
            print("You win!The word was {}".format(secret_word))
            break
    else:
        bad_guesses.append(guess)
else:
    print("You didnt guess it!@ My secret word was {}".format(secret_word))
I've cross-referenced it with the code of others and can't figure out why their's breaks after the word is guessed but mine just allows inputs after the word is guessed.

Steven Parker · Answer

Your win detection test is to compare the number of good guesses with the length of the word.  This will work, but only on words that have no repeated letters.  When a word has one or more repeated letters, it takes fewer guesses than the total number of letters to win.
To be able to work with words like "apple", you'll need to modifiy how you check for a win.  For examples, you might compare the number of good guesses with the number of unique letters, or you could check if every letter of the word has been guessed.

Welcome to the Treehouse Community

Looking to learn something new?

Oleksiy Kloc

Oleksiy Kloc

After word is guessed, the program doesn't break

1 Answer

Steven Parker

Steven Parker