Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript and the DOM (Retiring) Getting a Handle on the DOM Practice Selecting Elements

Posted by Adil Ismaaeel
Adil Ismaaeel
9,438 Points

Assigning links from ul to variable

Next, select all links inside the unordered list with the ID gallery and assign them to the variable galleryLinks.

I dont understand what I am doing wrong, the links within the ul are 'ul li a img li a img' but it keeps saying that zero links are selected. Not sure what to do

js/app.js 
let navigationLinks = document.querySelectorAll( 'nav ul a' );
let galleryLinks = document.querySelectorAll( ' ul li a img li a img ' );
let footerImages;
index.html 
<!DOCTYPE html>
<html>
  <head>
    <meta charset="utf-8">
    <title>Nick Pettit | Designer</title>
    <link rel="stylesheet" href="css/normalize.css">
    <link href='http://fonts.googleapis.com/css?family=Changa+One|Open+Sans:400italic,700italic,400,700,800' rel='stylesheet' type='text/css'>
    <link rel="stylesheet" href="css/main.css">
    <link rel="stylesheet" href="css/responsive.css">
    <meta name="viewport" content="width=device-width, initial-scale=1.0">
  </head>
  <body>
    <header>
      <a href="index.html" id="logo">
        <h1>Nick Pettit</h1>
        <h2>Designer</h2>
      </a>
      <nav>
        <ul>
          <li><a href="index.html" class="selected">Portfolio</a></li>
          <li><a href="about.html">About</a></li>
          <li><a href="contact.html">Contact</a></li>
        </ul>
      </nav>
    </header>
    <div id="wrapper">
      <section>
        <ul id="gallery">
          <li>
            <a href="img/numbers-01.jpg">
              <img src="img/numbers-01.jpg" alt="">
              <p>Experimentation with color and texture.</p>
            </a>
          </li>
          <li>
            <a href="img/numbers-02.jpg">
              <img src="img/numbers-02.jpg" alt="">
              <p>Playing with blending modes in Photoshop.</p>
            </a>
          </li>
        </ul>
      </section>
      <footer>
        <a href="http://twitter.com/nickrp"><img src="img/twitter-wrap.png" alt="Twitter Logo" class="social-icon"></a>
        <a href="http://facebook.com/nickpettit"><img src="img/facebook-wrap.png" alt="Facebook Logo" class="social-icon"></a>
        <p>&copy; 2016 Nick Pettit.</p>
      </footer>
    </div>
  <script src="js/app.js"></script>
  </body>
</html>

3 Answers

KRIS NIKOLAISEN
KRIS NIKOLAISEN
54,972 Points

Some hints:

  • You can use an id (preceded by a hash symbol) as a selector with querySelectorAll
  • In task 2 you are selecting links. These are the <a> tags like in the previous task
  • You can shorten your selector by using the first and last selectors in your descendent selector. For example in task 1 you could have used document.querySelectorAll( 'nav a' ) as well.
Adil Ismaaeel
Adil Ismaaeel
9,438 Points
Adil Ismaaeel
Adil Ismaaeel
9,438 Points

Thanks for helping me get through this

Thomas H
seal-mask
.a{fill-rule:evenodd;}techdegree
Thomas H
Full Stack JavaScript Techdegree Student 4,545 Points
Thomas H
.a{fill-rule:evenodd;}techdegree
Thomas H
Full Stack JavaScript Techdegree Student 4,545 Points

i was stuck at the same spot try this

let galleryLinks = document.querySelectorAll('#gallery a' );

I just change the order and it works