Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript jQuery Basics (2014) Creating a Simple Lightbox Adding New Attribute Values with attr()

Posted by Grayson Hicks
Grayson Hicks
10,006 Points

.attr Code Challenge

The code challenge is saying:

'Bummer! I was expecting 'target' to be '_blank' not ' '.'

My code is:

$(".external a").attr("target", "_blank");

Any help on fixing my code would be great, thanks!

js/app.js 
$(".external a").attr("target","_blank");
index.html 
<!DOCTYPE html>
<html>
<head>
  <link rel="stylesheet" href="css/style.css" type="text/css" media="screen" title="no title" charset="utf-8">
  <title>Links Page</title>
</head>
<body>
  <h1>Links</h1>
  <ul>
    <li><a href="http://google.com" class="external" target="">Google</a></li>
    <li><a href="http://yahoo.com" class="external" target="">Yahoo</a></li>
  </ul>
  <script src="//code.jquery.com/jquery-1.11.0.min.js" type="text/javascript" charset="utf-8"></script>
  <script src="js/app.js" type="text/javascript" charset="utf-8"></script>
</body>
</html>
Jesus Mendoza
Jesus Mendoza
23,289 Points
Jesus Mendoza
Jesus Mendoza
23,289 Points

Try using a.external or .external selector only. You're targeting all the anchors inside the tags with .external class.

1 Answer

geoffrey
geoffrey
28,736 Points
geoffrey
geoffrey
28,736 Points

The error comes from your selector.

the answer is this one:

$('.external').attr("target","_blank");

And on your side as selector you use this:

$('.external a')

See the difference ? On your side you are targeting all anchors sitting inside the .external elements. If you wanted to be more specific you could have done that thought

$('a.external')

Which means all anchors with the external class applied...

Grayson Hicks
Grayson Hicks
10,006 Points

Awesome, thanks.