Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Java Java Data Structures Efficiency! Implement Chooser UI

Liron Tal
Liron Tal
4,825 Points

byArtist() not working as expected

byArtist() is not working as expected, I tried 3 different songs of 2 artist, and artistSongs size was only 2. The reason is basically because we override artistSongs each iteration with byArtist.get(song.getArtist()); no matter how many times we added songs of the same artist to artistSongs..

private Map<String, List<Song>> byArtist() {
    Map<String, List<Song>> byArtist = new HashMap<>();
    for(Song song : mSongs) {
        List<Song> artistSongs = byArtist.get(song.getArtist());
        if(artistSongs == null) {
            artistSongs = new ArrayList<>();
            byArtist.put(song.getArtist(), artistSongs);
    return byArtist;

Debugged it and still not working as expected. Am I missing something?

Thanks, Liron