Welcome to the Treehouse Community

The Treehouse Community is a meeting place for developers, designers, and programmers of all backgrounds and skill levels to get support. Collaborate here on code errors or bugs that you need feedback on, or asking for an extra set of eyes on your latest project. Join thousands of Treehouse students and alumni in the community today. (Note: Only Treehouse students can comment or ask questions, but non-students are welcome to browse our conversations.)

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and a supportive community. Start your free trial today.

Android Build a Simple Android App Basic Android Programming Adding the OnClick Method

harry houdini
harry houdini
Android Development Techdegree Student 535 Points

Clicking button changes wrong Text box.

When the app runs, the "Did you know" text box changes to "Ostriches can run faster..." i.e. the FunFact box doesn't change, the "Did you know" box changes.

Below is my code: package com.treehouse.funfacts;

import android.support.v7.app.AppCompatActivity; import android.os.Bundle; import android.view.View; import android.widget.Button; import android.widget.TextView;

public class FunFacts extends AppCompatActivity { // Declare our View variables private TextView mFactTextView; private Button mShowFactButton;

protected void onCreate(Bundle savedInstanceState) {

    //Assign the Views from the layout file to the corresponding variables
    mFactTextView = (TextView) findViewById(R.id.factTextView);
    mShowFactButton = (Button) findViewById(R.id.showFactButton);

    View.OnClickListener listener = new View.OnClickListener(){
                public void onClick(View v  ){

            //The button was clicked, so update the fact TextView with a new fact
            String fact = "Ostriches can run faster than horses.";


}; mShowFactButton.setOnClickListener(listener); } }

2 Answers

it is doing its job ?? what do you want to change ?? Button text .. if yes then add line inside click listener mShowFactButton.setText(fact);

York Brady
York Brady
1,053 Points

Your code looks fine on this page, so it sounds like you assigned the "factTextView" id to the wrong TextView on your "activity_fun_facts.xml" page. Check to see which TextView you assigned that ID to.