Data entered by user does not stay in the list. help!!

Question

Every time a name is entered it is being overridden by the next item that comes from user next. The last name entered becomes the only name left in the list but listed repeatedly. Heres my code:

da_roster = []

while True:
    add_player = input("Would you would you like to add some players the team? Yes or No?  ")
    if add_player.lower() == 'yes':
        player_name = input("What is the name of the player?  ")
        da_roster.append(player_name)
        print()
    if add_player.lower() =='no':
        break
else:
    print(da_roster)
print("There are", len(da_roster), "players on the team.")

count = 1

for player in da_roster:
    print(f"{player_name} is player nunmber {count}.")
    count += 1 

print(f"Please select a goal keeper from your team. Choose player 1 - {len(da_roster)}.")
goalie = int(input())

print(f"Your goal keeper for this game will be...{da_roster[goalie]}") 


# Remember that lists use a zero based index

Answer 1 · 2020-01-10T19:33:46Z

January 10, 2020 7:33pm

Some comments

1) Your while condition will never be false so not sure what this code is doing

else:
    print(da_roster)

2) You should use player instead of player_name here:

for player in da_roster:
    print(f"{player} is player nunmber {count}.")
    count += 1

player_name is the variable you used to store input and will have the value of the last assignment

3) The list starts with index 0 so to get the correct item you will need to subtract 1 here:

goalie = int(input()) - 1

Welcome to the Treehouse Community

Looking to learn something new?

Marquis Hurley

Marquis Hurley

Data entered by user does not stay in the list. help!!

1 Answer

KRIS NIKOLAISEN

KRIS NIKOLAISEN

Marquis Hurley

Marquis Hurley