Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript jQuery Basics (2014) Creating a Simple Lightbox Adding New Attribute Values with attr()

Posted by Thomas Katalenas
Thomas Katalenas
11,033 Points

didn't set target links.

I think attributes maybe?

js/app.js 
var $external = $(".external");
var $target = $("_blank");
$external.append($target);
index.html 
<!DOCTYPE html>
<html>
<head>
  <link rel="stylesheet" href="css/style.css" type="text/css" media="screen" title="no title" charset="utf-8">
  <title>Links Page</title>
</head>
<body>
  <h1>Links</h1>
  <ul id="img">
    <li><a href="http://google.com" class="external">Google</a></li>
    <li><a href="http://yahoo.com" class="external">Yahoo</a></li>
  </ul>
  <script src="//code.jquery.com/jquery-1.11.0.min.js" type="text/javascript" charset="utf-8"></script>
  <script src="js/app.js" type="text/javascript" charset="utf-8"></script>
</body>
</html>

1 Answer

Steven Parker
Steven Parker
229,787 Points
Steven Parker
Steven Parker
229,787 Points

Yes, the challenge says to set the attributes, so part of it is that you need attr instead of append. But you're also trying to build a JQuery object that you don't need using "_blank" as a selector (which will certainly be an empty set). And though you can get away with targeting just the class external, they do ask for links (a elements) with that class, so your selector would ideally be: a.external.

The easy solution to this is just a one-liner:

:warning: SPOILER ALERT

app.js 
$("a.external").attr("target", "_blank");