Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Android

Kyle Baker
Kyle Baker
8,211 Points

first android app

If you guys/gals wanna review it, that would be boss. It's pending atm, but I'm sure it'll be done soon. It's called "Score Keep" and it basically keeps the score for a two player game.

EDIT: here is the link to the app that I want reviewed https://play.google.com/store/apps/details?id=kybacorps.com.scorekeep

Simon Coates
Simon Coates
28,694 Points

um, what exactly do you want reviewed? You don't seem to have posted any material.

Kyle Baker
Kyle Baker
8,211 Points

Simon Coates i added an edit with link to app i want reviewed, thanks for the question :)

Kyle Baker
Kyle Baker
8,211 Points

@Simon Coates thanks for the tips, I think I'll implement all of em. Do you have a link for the greyscale test btw? Tried looking it up myself but I don't think I found the right test. Thanks again :)

Simon Coates
Simon Coates
28,694 Points

I've seen it mentioned on treehouse and lynda.com in web courses. not sure which ones, though. The test might actually be for the benefit of the color blind (the accessibility issue), but once in greyscale color disappears and you're left with tone. Greyscale forces you to think about light/dark contrast. As a general principle i think color distinctions aid UI design, but in this specific case I have slight difficulty picking the black underline and text on the dark blue background. On another note, instead of calling your button 'enter', you might label it 'set'.

Ben Deitch
Ben Deitch
Treehouse Teacher

This is awesome, great job! And if you're looking for feedback, I'd echo Simon's comments about the colors; they should contrast a lot more. If you're interested, here's a link to what Google has to say about color in material design.

Kyle Baker
Kyle Baker
8,211 Points

@Ben Deitch thanks alot for the kind words and the response in general :) I watched the video that your link sent me to but I'm a little confused at what the values mean. For instance, they had 300 as light, 500 as mid and 700 as dark but idk what that corresponds to in regard to rgb or hexadecimal.

As for my app though, I did alter my colors already as Simon suggested but I'm still working on getting the app not to crash from large numbers. I'm probably going to use an if statement since try catch didn't work out and I read it's costly on performance anyways.

Sorry for the essay response but I thought I'd let you know what my plans are :) and thanks a ton for making it possible

Ben Deitch
Ben Deitch
Treehouse Teacher

It's basically just the intensity of the color on a scale from 0-1000. So pink 200 is a soft whitish pink, whereas pink 900 is a much deeper intense pink. If you scroll down on that page there's a bunch of examples with hex codes :)

Kyle Baker
Kyle Baker
8,211 Points

@Ben Deitch oops, didn't know that's what was hiding in the color palette tab. Thank you for pointing it out :).

1 Answer

Simon Coates
Simon Coates
28,694 Points

1) seems to crash when i enter a large score. 2) a scorekeeping app might usually have an ability to set names. 3) the initial colors that show up seem to be a dark red and a dark blue. black on quite a dark background is a little odd, i think. It might be pretty subjective, but i would have gone with gentler colors, bit of gap under the buttons, and ensure all the various UI elements had contrast (and looked good with the greyscale test). To be clear, I'm not a UI expert.