getCountOfLetter 2/2

Question

Whats wring with my code

ScrabblePlayer.java

public class ScrabblePlayer {
  // A String representing all of the tiles that this player has
  private String tiles;

  public ScrabblePlayer() {
    tiles = "";
  }

  public String getTiles() {
    return tiles;
  }

  public void addTile(char tile) {
    tiles += tile;
  }

  public boolean hasTile(char tile) {
    return tiles.indexOf(tile) != -1;
  }
  public int getCountOfLetter(char letter){
    for(char letter : tiles.toCharArray){
    if(letter = indexOfTile(tiles)! =-1{
      letter = count}
    }

    return count;

  }
}

Example.java

// This code is here for example purposes only
public class Example {

  public static void main(String[] args) {
    ScrabblePlayer player1 = new ScrabblePlayer();
    player1.addTile('d');
    player1.addTile('d');
    player1.addTile('p');
    player1.addTile('e');
    player1.addTile('l');
    player1.addTile('u');

    ScrabblePlayer player2 = new ScrabblePlayer();
    player2.addTile('z');
    player2.addTile('z');
    player2.addTile('y');
    player2.addTile('f');
    player2.addTile('u');
    player2.addTile('z');

    int count = 0;
    // This would set count to 1 because player1 has 1 'p' tile in her collection of tiles
    count = player1.getCountOfLetter('p');
    // This would set count to 2 because player1 has 2 'd'' tiles in her collection of tiles
    count = player1.getCountOfLetter('d');
    // This would set 0, because there isn't an 'a' tile in player1's tiles
    count = player1.getCountOfLetter('a');

    // This will return 3 because player2 has 3 'z' tiles in his collection of tiles
    count = player2.getCountOfLetter('z');
    // This will return 1 because player2 has 1 'f' tiles in his collection of tiles
    count = player2.getCountOfLetter('f');
  }
}

Answer 1 · 2018-03-07T03:08:28Z

March 7, 2018 3:08am

Hi Zach

Example class is a different class to ScrabblePlayer class. You cannot directly access count variable that was declared in a different class, let alone assigns it directly to a method inside a different class.

Moreover in your original code, you need to increment the count variable, not assign it to the letter which also will invoke error because letter is char type object while count is supposed to be an int (even if you take the example class count variable as reference).

Answer 2 · 2018-03-06T03:36:19Z

March 6, 2018 3:36am

Hi Zachary...

This is where your code needs revision:

public int getCountOfLetter(char letter){
    for(char letter : tiles.toCharArray){//<- this has conflict with argument letter passed
    if(letter = indexOfTile(tiles)! =-1{//<- you cannot do this better of if you are asking if letter = ....
      letter = count}//<-- you have not declared what is count yet and also this is not how you should do this
    }
 return count;

  }

This is how you should revise your code:

public int getCountOfLetter(char letter){
    int count = 0;//<- declaring and initializing the count variable
    for(char tile : tiles.toCharArray()){ //<- this is how you iterate all chars inside a String
      if(tile == letter) {//<-this is the correct IF the tile from the tiles matches the letter
        count++;//<-- if it is a match count variable will be incremented by 1
      }
    }
    return count;
  }

I hope this can help a little

Welcome to the Treehouse Community

Looking to learn something new?

Zachary Martin

Zachary Martin

getCountOfLetter 2/2

2 Answers

Yanuar Prakoso

Yanuar Prakoso

Yanuar Prakoso

Yanuar Prakoso

Zachary Martin

Zachary Martin