How can I improve my logic

Question

I finished the practice differently from the video, but it works lol. Just wanted someone to overview my code to give pointers on what i could improve on.

team = []

add_members= input("Would You Like To Add Players To The Team? (Yes/No): ").upper()

def Add_Teammates():
    going = True
    while going:
        team.append(input("Enter Player Name: ").upper())
        print(team)
        adding = input("Add Another? ").upper()
        if adding == "YES":
            continue
        else:
            going = False


if add_members == "YES":
    Add_Teammates()
else:
    print(team)

print(f"The current roster size is {len(team)} and the members are: ")
team_num = 0
for member in team:
    team_num += 1
    print(f"{member.upper()} {team_num}")

goalkeeper = int(input("Select a Goaly from the team by entering the player's number: "))
print(f"You Selected {team[goalkeeper-1]} as the team GoalKeeper")

Answer 1 · 2022-05-11T07:12:05Z

May 11, 2022 7:12am

You can eliminate the variables from the function:

def Add_Teammates():
    while True:
        team.append(input("Enter Player Name: ").upper())
        print(team)
        if input("Add Another? ").upper() != "YES":
            break

Welcome to the Treehouse Community

Looking to learn something new?

JaeVeine Covington

JaeVeine Covington

How can I improve my logic

1 Answer

Steven Parker

Steven Parker