How to check for $ in normalizeDiscountCode and why I get wrong ouput when running the tests.

Question

When i run the test it gets an error message when trying to run the "h1l" string where it does not throw an IllegalArgumentException correctly. When trying to print out the for-loop it says it throws an exception at that point but the tests doesnt recognize it. Also cant get the check for the dollar sign to work as intended.

Order.java

public class Order {
  private String itemName;
  private int priceInCents;
  private String discountCode;

  public Order(String itemName, int priceInCents) {
    this.itemName = itemName;
    this.priceInCents = priceInCents;
  }

  public String getItemName() {
    return itemName;
  }

  public int getPriceInCents() {
    return priceInCents;
  }

  public String getDiscountCode() {
    return discountCode;
  }

  public void applyDiscountCode(String discountCode) {
    try {
      this.discountCode = normalizeDiscountCode(discountCode);
    } catch (IllegalArgumentException iae){
        System.out.println(iae.getMessage());
    }
  }

  private String normalizeDiscountCode(String discountCode){
    for (char letter : discountCode.toCharArray()){
      if (!Character.isLetter(letter) && letter != '$'){
        throw new IllegalArgumentException("Invalid discount code");
      }
    }
    return discountCode.toUpperCase();
  }
}

Example.java

public class Example {

  public static void main(String[] args) {
    // This is here just for example use cases.

    Order order = new Order(
            "Yoda PEZ Dispenser",
            600);

    // These are valid.  They are letters and the $ character only
    order.applyDiscountCode("abc");
    order.getDiscountCode(); // ABC

    order.applyDiscountCode("$ale");
    order.getDiscountCode(); // $ALE


    try {
      // This will throw an exception because it contains numbers
      order.applyDiscountCode("ABC123");
    } catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }
    try {
      // This will throw as well, because it contains a symbol.
      order.applyDiscountCode("w@w");
    }catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }

  }
}

Welcome to the Treehouse Community

Looking to learn something new?

Jan Erik Lizcano Ladegård

Jan Erik Lizcano Ladegård

How to check for $ in normalizeDiscountCode and why I get wrong ouput when running the tests.