Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript Object-Oriented JavaScript Getters and Setters Creating Getter Methods

Kaya Jackson
seal-mask
.a{fill-rule:evenodd;}techdegree
Kaya Jackson
Full Stack JavaScript Techdegree Student 8,734 Points
Posted by Kaya Jackson
.a{fill-rule:evenodd;}techdegree
Kaya Jackson
Full Stack JavaScript Techdegree Student 8,734 Points

I can't figure out what's wrong.

I looked at other examples and I can't find the error in my code.

creating_getters.js 
class Student {
    constructor(gpa, credits){
        this.gpa = gpa;
        this.credits = credits;
    }

  get level() {
      if(this.credits > 90) {
        return 'Senior';
    } else if(this.credits < 90 && this.credits >= 61) {
        return 'Junior'; 
    } else if (this.credits < 60 && this.credits >= 31) {
        return 'Sophmore'; 
    } else if (this.credits < 30) {
        return 'Freshman'; 
    }
  }

    stringGPA() {
        return this.gpa.toString();
    }
}

const student = new Student(3.9);

2 Answers

Steven Parker
Steven Parker
229,644 Points
Steven Parker
Steven Parker
229,644 Points

I see these issues:

  • range limits are not correct — values of 30, 60, and 90 don't currently return anything
  • the word 'Sophmore' is misspelled (should be "Sophomore")
  • (optionally) the code can be simplified by not re-testing conditions eliminated by previous "if"s

For example:

  get level() {
    if (this.credits > 90) {
      return "Senior";
    } else if (this.credits > 60) {
      return "Junior";
    } else if (this.credits > 30) {
      return "Sophomore";
    } else {
      return "Freshman";
    }
  }