Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Java Java Objects Delivering the MVP Applying a Discount Code

Nikki Wong
Nikki Wong
9,066 Points

I can't figure out what's wrong with my code. :(

I keep getting errors no matter what I try...

Order.java
public class Order {
  private String itemName;
  private int priceInCents;
  private String discountCode;

  private String normalizeDiscountCode(String code){
    for (char letter: code.toCharArray()) {
        if(! Character.isLetter(letter) || letter!='$') {
           throw new IllegalArgumentException("Invalid discount code.");
        }
    }
    return code.toUpperCase();
  }

  public Order(String itemName, int priceInCents) {
    this.itemName = itemName;
    this.priceInCents = priceInCents;
  }

  public String getItemName() {
    return itemName;
  }

  public int getPriceInCents() {
    return priceInCents;
  }

  public String getDiscountCode() {
    return discountCode;
  }

  public void applyDiscountCode(String discountCode) {
    this.discountCode = normalizeDiscountCode(discountCode);
  }
}
Example.java
public class Example {

  public static void main(String[] args) {
    // This is here just for example use cases.

    Order order = new Order(
            "Yoda PEZ Dispenser",
            600);

    // These are valid.  They are letters and the $ character only
    order.applyDiscountCode("abc");
    order.getDiscountCode(); // ABC

    order.applyDiscountCode("$ale");
    order.getDiscountCode(); // $ALE


    try {
      // This will throw an exception because it contains numbers
      order.applyDiscountCode("ABC123");
    } catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }
    try {
      // This will throw as well, because it contains a symbol.
      order.applyDiscountCode("w@w");
    }catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }

  }
}

1 Answer

michaelcodes
michaelcodes
5,604 Points

Hi there! you are very close, the only problem is that you have used || or operator when you need && operator here:

        if(! Character.isLetter(letter) && letter!='$') {

This is this logic of it. If it is not a letter, we have to make sure it is also not a $ sign. If we used or here it would throw an exception almost every time If it was not a letter, or not the $ sign. This means even if its not a letter with the first check, since every letter is not a dollar sign it will only allow dollar signs to pass through and not throw exception.

Hope this helps, if you have any more questions let me know!

Take care and happy coding

Nikki Wong
Nikki Wong
9,066 Points

Thank you!! makes sense!