Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript jQuery Basics Working with jQuery Collections Looping through a jQuery collection

Tomasz Grodzki
Tomasz Grodzki
8,130 Points
Posted by Tomasz Grodzki
Tomasz Grodzki
8,130 Points

I wrote a little bit shorter loop. It works but I don't know if it's good

Like in the title: is this loop good? I know that it works, but maybe this syntax isn't too good for bigger projects?

const $odd = $('a:odd');
const $secureLinks = $('a[href^="https://"]');
const $pdfs = $('a[href$=".pdf"]');
const $button = $("<label><input type='checkbox'> Allow PDF downloads</label>");

$secureLinks.attr( 'target', '_blank' );
$pdfs.attr ( 'download', true );

$secureLinks.addClass( 'secure' );
$pdfs.addClass( 'pdf' );

$($pdfs).on( 'click', () => 
{
    if ( $(':checked').length === 0 )
    {
        event.preventDefault();
    }

});

$('div#links').append ($button);

$('a').each ( function ()
{
    $(this).parent().append( ` (${this.href}) ` );
});

<!DOCTYPE html>
<html>
<head>
    <title>jQuery Weekly</title>
    <link rel="stylesheet" href="css/style.css" type="text/css" media="screen" title="no title" charset="utf-8">
</head>
<body>
<div class="box">
    <h1>jQuery Weekly</h1>
    <div id="links">
        <ul>
            <li><a href='https://learn.jquery.com/'>Learn jQuery</a></li>
            <li><a href='http://treehouse-project-downloads.s3.amazonaws.com/jquery-basics/jquery_cheatsheet.pdf'>jQuery Cheatsheet</a></li>
            <li><a href='https://api.jquery.com/'>jQuery Documentation</a></li>
            <li><a href='https://developer.mozilla.org/en-US/docs/Glossary/jQuery'>jQuery Glossary</a></li>
        </ul>

    </div>
</div>
    <script src="js/jquery-3.2.1.min.js"></script>
    <script src="js/app.js"></script>
</body>
</html>

1 Answer

Thom Benjamin
Thom Benjamin
10,494 Points
Thom Benjamin
Thom Benjamin
10,494 Points

Good work, brother! As long as it works, is shorter, and clear for you and others, it's good! Couldn't say if it's good for bigger projects, that depends on every project. It's more important that it works here. :)

Tomasz Grodzki
Tomasz Grodzki
8,130 Points
Tomasz Grodzki
Tomasz Grodzki
8,130 Points

I see :) Thanks for the response!