Welcome to the Treehouse Community
Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.
Looking to learn something new?
Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.
Start your free trial
Mark Biggin
4,921 PointsI'm having the same issue - Oops! It looks like Task 1 is no longer passing.
I'm having the same issue - Oops! It looks like Task 1 is no longer passing.
Removed live 27 to complete task 1
Added change to line 29
Completely removed live 27, have even tried removing live 26 which is the same as the project files
I've never been this stuck before :-(
//Problem: It look gross in smaller browser widths and small devices
//Solution: To hide the text links and swap them out with a more appropriate navigation
//Create a select and append to #menu
var $select = $("<select></select>");
$("#menu").append($select);
//Cycle over menu links
$("#menu a").each(function(){
var $anchor = $(this);
//Create an option
var $option = $("<option></option>");
//Deal with selected options depending on current page
if($anchor.parent().hasClass("selected")) {
$option.prop("selected", true);
}
//option's value is the href
$option.val($anchor.attr("href"));
//option's text is the text of link
$option.text($anchor.text());
//append option to select
$select.append($option);
});
//Create button
var $button = $("<button>Go</button>");
$("#menu").append($button);
//Bind click to button
$button.click(function(){
//Go to select's location
window.location = $select.val();
});
<!DOCTYPE html>
<html>
<head>
<link rel="stylesheet" href="css/style.css" type="text/css" media="screen" title="no title" charset="utf-8">
</head>
<body>
<div id="menu">
<ul>
<li class="selected"><a href="index.html">Home</a></li>
<li><a href="about.html">About</a></li>
<li><a href="contact.html">Contact</a></li>
<li><a href="support.html">Support</a></li>
<li><a href="faqs.html">FAQs</a></li>
<li><a href="events.html">Events</a></li>
</ul>
</div>
<h1>Home</h1>
<p>This is the home page.</p>
<script src="//code.jquery.com/jquery-1.11.0.min.js" type="text/javascript" charset="utf-8"></script>
<script src="js/app.js" type="text/javascript" charset="utf-8"></script>
</body>
</html>
4 Answers
Colin Bell
29,679 Points25 //Create button
26 var $button = $("<button>Go</button>");
27 $("#menu").append($button); //<--- Step 1.) Remove this
28 //Bind click to button
29 $button.click(function(){ //<---- Step 2.) Change this
30 //Go to select's location
31 window.location = $select.val();
32 });
As it is originally written, the redirect happens when $button is clicked. The challenge is asking you to change it so that the redirect happens when $select is changed.
28 //Bind click to button ---> 28 //Bind change to select
25 //Create button
26 var $button = $("<button>Go</button>");
27 //<--- Step 1.) Remove this
28 //Bind change to select
29 $select.change(function(){ //<---- Step 2.) Change this
30 //Go to select's location
31 window.location = $select.val();
32 });
Mark Biggin
4,921 PointsThanks Colin,
Ha! I think I know where I've gone wrong...
Colin Bell
29,679 PointsHmmm, it's passing for me.
Can you post the exact code you're submitting so I can take a look, please?
Mark Biggin
4,921 PointsGot it now - I'd missed select, either late in the day or I've not fully taken it on board - thanks again!
mattiapontonio
14,991 PointsI has the same issue. Leave the line 27 blanck and be sure to use $select instead of $button.