Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Java Java Objects Delivering the MVP Applying a Discount Code

In the normalizeDiscountCode verify that only letters or the $ character are used. What's wrong with my code?

The console says that problem in IF statement.

Order.java
public class Order {
  private String itemName;
  private int priceInCents;
  private String discountCode;

  public Order(String itemName, int priceInCents) {
    this.itemName = itemName;
    this.priceInCents = priceInCents;
  }

  private String normalizeDiscountCode(String discountCodeNorm) 
  {
    discountCodeNorm=discountCodeNorm.toUpperCase();
    for (char i:discountCodeNorm.toCharArray())
    {

      if ( ( (i>='A')&&(i<='Z') )||(i='$') ) 
      {
        return discountCodeNorm;
      }
      else 
      {
        throw new IllegalArgumentException("Invalid discount code");
      }

    }
  }    


  public String getItemName() {
    return itemName;
  }

  public int getPriceInCents() {
    return priceInCents;
  }

  public String getDiscountCode() {
    return discountCode;
  }

  public void applyDiscountCode(String discountCode) {
    this.discountCode = discountCode;
    this.discountCode = normalizeDiscountCode(discountCode);

  }
}
Example.java
public class Example {

  public static void main(String[] args) {
    // This is here just for example use cases.

    Order order = new Order(
            "Yoda PEZ Dispenser",
            600);

    // These are valid.  They are letters and the $ character only
    order.applyDiscountCode("abc");
    order.getDiscountCode(); // ABC

    order.applyDiscountCode("$ale");
    order.getDiscountCode(); // $ALE


    try {
      // This will throw an exception because it contains numbers
      order.applyDiscountCode("ABC123");
    } catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }
    try {
      // This will throw as well, because it contains a symbol.
      order.applyDiscountCode("w@w");
    }catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }

  }
}

1 Answer

Ronald Williams
seal-mask
.a{fill-rule:evenodd;}techdegree seal-36
Ronald Williams
Java Web Development Techdegree Graduate 25,021 Points

Hello, in the second part of your for loop you have i='$' instead you want i != '$'

i = '$' means make the variable i hold the char value '$'

i == '$' means true or false, the variable held in i is the same as '$'

i != '$' means true or false the variable held in i is NOT the same as '$'

Here is a possible solution to this challenge:

  public void applyDiscountCode(String discountCode) {
    this.discountCode = normalizeDiscountCode(discountCode);
  }

  private String normalizeDiscountCode(String discountCode) {
      for (char i: discountCode.toCharArray()) {
        if (!Character.isLetter(i) && i != '$') {
          throw new IllegalArgumentException("Invalid discount code");
        }
      }
      discountCode = discountCode.toUpperCase();
      return discountCode;
  }