Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript AJAX Basics (retiring) AJAX and APIs Displaying the Photos

Posted by Kevin Anderson
Kevin Anderson
14,569 Points

Instead of an image I get "NaNhttps://farm3.staticflickr.com/2872/32801359003_de2a7073f2_m.jpg">" to the HTML.

Instead of an image I get:

NaNhttps://farm3.staticflickr.com/2872/32801359003_de2a7073f2_m.jpg">

to the HTML.

$(document).ready(function () {
  $('button').click(function() {
  $('button').removeClass('selected');  
    $(this).addClass("selected");
    var flickerAPI = "https://api.flickr.com/services/feeds/photos_public.gne?jsoncallback=?";
    var animal = $(this).text();
    var flickrOptions = {
      tags: animal,
      format: "json" 
    };
    function displayPhotos(data) {
      var photoHTML = '<ul>';
      $.each( data.items, function (i, photo) {
        photoHTML += '<li class="grid-25 tablet-grid-50">';
        photoHTML += '<a href="' + photo.link + '" class="image">';
        photoHTML =+ '<img src="' + photo.media.m + '"></a></li>';
      });
      photoHTML += '</ul>';
      $('#photos').html(photoHTML);
    };
    $.getJSON(flickerAPI, flickrOptions, displayPhotos);
  });
}); // end ready

1 Answer

Sergey Podgornyy
Sergey Podgornyy
20,660 Points
Sergey Podgornyy
Sergey Podgornyy
20,660 Points

You have an error in this string:

photoHTML =+ '<img src="' + photo.media.m + '"></a></li>';

Instead of =+ use +=

Kevin Anderson
Kevin Anderson
14,569 Points

Thank you. I have been searching for it for days. How did I miss that!!

Sergey Podgornyy
Sergey Podgornyy
20,660 Points
Sergey Podgornyy
Sergey Podgornyy
20,660 Points

You are welcome :blush: But nevertheless I suggest you rewrite your code like this one:

$(document).ready(function () {
    $('button').click(function () {
        $('button').removeClass('selected');  
        $(this).addClass("selected");
        var flickerAPI = "https://api.flickr.com/services/feeds/photos_public.gne?jsoncallback=?",
            animal = $(this).text(),
            flickrOptions = {
                tags: animal,
                format: "json" 
            };
        function displayPhotos(data) {
            var items = data.items.reduce(function (sum, current) {
                return sum
                    + '<li class="grid-25 tablet-grid-50">'
                    + '    <a href="' + current.link + '" class="image">'
                    + '        <img src="' + current.media.m + '">'
                    + '    </a>'
                    + '</li>';
            }, '');
            $('#photos').html('<ul>' + items + '</ul>');
        };

        $.getJSON(flickerAPI, flickrOptions, displayPhotos);
  });
});

It looks a little bit clearer :wink: