Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community!

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Java Java Objects Delivering the MVP Applying a Discount Code

mmm...I ran order.applyDiscountCode("h1!") and I expected it to throw an IllegalArgumentException, but it didn't

Anything helps

public class Order {
  private String itemName;
  private int priceInCents;
  private String discountCode;

  private String normalizeDiscountCode(String discountCode)  {
    for (char values : discountCode.toCharArray()){
      if (Character.isLetter(values) && discountCode.indexOf("$") != -1) {
          throw new IllegalArgumentException("Invalid discount code");  
      this.discountCode = discountCode;
      return discountCode.toUpperCase();

  public Order(String itemName, int priceInCents) {
    this.itemName = itemName;
    this.priceInCents = priceInCents;

  public String getItemName() {
    return itemName;

  public int getPriceInCents() {
    return priceInCents;

  public String getDiscountCode() {
    return discountCode;

  public void applyDiscountCode(String discountCode) {
    this.discountCode = normalizeDiscountCode(discountCode);
public class Example {

  public static void main(String[] args) {
    // This is here just for example use cases.

    Order order = new Order(
            "Yoda PEZ Dispenser",

    // These are valid.  They are letters and the $ character only
    order.getDiscountCode(); // ABC

    order.getDiscountCode(); // $ALE

    try {
      // This will throw an exception because it contains numbers
    } catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    try {
      // This will throw as well, because it contains a symbol.
    }catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"


1 Answer

In the normalizeDiscountCode method, an exception will only be thrown if the character is a letter and the string contains a '$' character. Since "h1!" doesn't contain a '$' character it will always be false.

To fix this you should first move: discountCode.indexOf("$") != -1 outside of the loop because it is checking it for every character. If the discount code is only supposed to have characters you need to replace Character.isLetter(values) with !Character.isLetter(values)