Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript

Joseph Yap
seal-mask
.a{fill-rule:evenodd;}techdegree
Joseph Yap
Full Stack JavaScript Techdegree Student 1,764 Points
Posted by Joseph Yap
.a{fill-rule:evenodd;}techdegree
Joseph Yap
Full Stack JavaScript Techdegree Student 1,764 Points

My Solution for the challenge: Feedback would be strongly appreciated!

let html = '';
let randomRGB;

for(let i = 1; i <= 10; i++){
randomRGB = randColor(Math.floor(Math.random() * 256), Math.floor(Math.random() * 256), Math.floor(Math.random() * 256));
html += `<div style="background-color: ${randomRGB}">${i}</div>`;
document.querySelector('main').innerHTML = html;
}

function randColor(r, g, b){
let randomRGB = `rgb(${r}, ${g}, ${b})`;
return randomRGB;
}

1 Answer

Steven Parker
Steven Parker
231,248 Points
Steven Parker
Steven Parker
231,248 Points

Just a few suggestions:

  • for readability, use indentation to indicate nesting levels (but good job using Markdown formatting!)
  • setting the innerHTML of <main> can be done just once, after the loop
  • you could optionally make things more compact using a function for picking the random values