Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Java Java Objects Delivering the MVP Applying a Discount Code

No compile errors. Program says that after passing the first task the second task no longer passes the first task

I don't see how this interferes with task number one after I complete task number two

Order.java
public class Order {
  private String itemName;
  private int priceInCents;
  private String discountCode;

  public Order(String itemName, int priceInCents) {
    this.itemName = itemName;
    this.priceInCents = priceInCents;
  }

  public String getItemName() {
    return itemName;
  }

  public int getPriceInCents() {
    return priceInCents;
  }

  public String getDiscountCode() {
    return discountCode;
  }

  public void applyDiscountCode(String discountCode) {
    this.discountCode = normalizeDiscountCode(discountCode);
  }

  private String normalizeDiscountCode(String discountCode) { 

   // String normalCode = "";

    for (int index = 0; index <= discountCode.length(); index++)
    {
      char codeChar = discountCode.charAt(index);

      if (Character.isLetter(codeChar) || codeChar == '$')
      {

      }else 
      {
        throw new IllegalArgumentException("Invalid discount code."); 
      } 
    }
    discountCode.toUpperCase();
    return discountCode; 
  }
}
Example.java
public class Example {

  public static void main(String[] args) {
    // This is here just for example use cases.

    Order order = new Order(
            "Yoda PEZ Dispenser",
            600);

    // These are valid.  They are letters and the $ character only
    order.applyDiscountCode("abc");
    order.getDiscountCode(); // ABC

    order.applyDiscountCode("$ale");
    order.getDiscountCode(); // $ALE


    try {
      // This will throw an exception because it contains numbers
      order.applyDiscountCode("ABC123");
    } catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }
    try {
      // This will throw as well, because it contains a symbol.
      order.applyDiscountCode("w@w");
    }catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }

  }
}

Change the for-loop of your normalizeDiscount method to: for(char c : discountCode.lenght()) { if(! Character.isLetter(c) && c != '$' { throw new IllegalArgumentException("error!") }}

it says: For every character of the word discountCode check if the character is not a letter AND not a dollar sign. If that is true, (than the character should be something like these: %^&) than throw a IllegalArgumentExeption.

1 Answer

Seth Kroger
Seth Kroger
56,413 Points

The for loop looks OK, and by that I mean logically correct. The empty if block is stylistically questionable and it would be better to invert the condition but it works.

On the two last lines of normalizeDiscountCode() you're returning the discount code unchanged:

    discountCode.toUpperCase();
    return discountCode;

toUpperCase() returns a new string. Since the result isn't returned immediately or stored in a variable it gets discarded.