Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript jQuery Basics (2014) Creating a Mobile Drop Down Menu Using each()

Shubham Modi
Shubham Modi
5,799 Points
Posted by Shubham Modi
Shubham Modi
5,799 Points

On line 9 of app.js, use the method we used to cycle over each of the menu links. Pass in an anonymous function too.

how do i do it

js/app.js 
//Problem: It look gross in smaller browser widths and small devices
//Solution: To hide the text links and swap them out with a more appropriate navigation

//Create a select and append to #menu
var $select = $("<select></select>");
$("#menu").append($select);

//Cycle over menu links
$("#menu a").each(function(){
  var $anchor = $(this);
  //Create an option
  var $option = $("<option></option>");
  //option's value is the href
$option.val($anchor.attr("href"));
  //option's text is the text of link
$option.text($anchor.text());
  //append option to select
$select.aoopend($option);
});
//Create button 
//Bind click to button
  //Go to select's location
//Modify CSS to hide links on small width and show button and select
  //Also hides select and button on larger width and show's links
//Deal with selected options depending on current page
index.html 
<!DOCTYPE html>
<html>
<head>
<link rel="stylesheet" href="css/style.css" type="text/css" media="screen" title="no title" charset="utf-8">
</head>
<body>
    <div id="menu">
        <ul>
            <li class="selected"><a href="index.html">Home</a></li>
            <li><a href="about.html">About</a></li>
            <li><a href="contact.html">Contact</a></li>
            <li><a href="support.html">Support</a></li>
            <li><a href="faqs.html">FAQs</a></li>
            <li><a href="events.html">Events</a></li>
        </ul>
    </div>
    <h1>Home</h1>
    <p>This is the home page.</p>
    <script src="//code.jquery.com/jquery-1.11.0.min.js" type="text/javascript" charset="utf-8"></script>
    <script src="js/app.js" type="text/javascript" charset="utf-8"></script>
</body>
</html>

1 Answer

Tobias Helmrich
Tobias Helmrich
31,602 Points
Tobias Helmrich
Tobias Helmrich
31,602 Points

Hey Shubham,

you already correctly added the each method and passed it an anonymous function and that's all you have to do in this challenge so just remove the code in your anonymous function as an empty anonymous function is enough in this case.

Oh and I noticed you have a typo here:

$select.aoopend($option);

where you wrote "aoopend" instead of "append".

Here's the solution for the challenge, like I said you actually had it right but you shouldn't add code to the function.

//Cycle over menu links
$("#menu a").each(function() {

});

I hope that helps! :)