Welcome to the Treehouse Community

The Treehouse Community is a meeting place for developers, designers, and programmers of all backgrounds and skill levels to get support. Collaborate here on code errors or bugs that you need feedback on, or asking for an extra set of eyes on your latest project. Join thousands of Treehouse students and alumni in the community today. (Note: Only Treehouse students can comment or ask questions, but non-students are welcome to browse our conversations.)

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and a supportive community. Start your free trial today.

Python Django REST Framework Security and Customization Validate Two Fields

Nathan Magyar
Nathan Magyar
11,332 Points

Serializer Custom Validator

In this challenge I need to write a custom validator for the PlayerSerializer, checking that players with an age of less than 13 have parental_approval. If they don't, I should raise a ValidationError to that effect.

When I run the attached code I receive this message: A young player was accepted as valid without parental approval!; A young player was reject even with approval!

Thanks for the help.

scorekeeper/serializers.py
from rest_framework import serializers

from . import models


class GameSerializer(serializers.ModelSerializer):
    class Meta:
        fields = ('id', 'name')
        model = models.Game


class PlayerSerializer(serializers.ModelSerializer):
    class Meta:
        fields = ('id', 'name', 'age', 'parent_approval')
        model = models.Player

    def validate(self, data):
        """
        Check that players under 13 have parental approval
        """
        if data['age'] < 13:
            if not data['parental_approval']:
                raise serializers.ValidationError('Children under 13 require parental approval')
            return data
        return data


class ScoreSerializer(serializers.ModelSerializer):
    game = serializers.HyperlinkedRelatedField(
        read_only=True, view_name='apiv2:game-detail')
    player = serializers.HyperlinkedRelatedField(
        read_only=True, view_name='apiv2:player-detail')

    class Meta:
        fields = ('id', 'game', 'player', 'score')
        model = models.Score