Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript jQuery Basics (2014) Creating a Simple Lightbox Adding New Attribute Values with attr()

Martin Coutts
Martin Coutts
18,154 Points
Posted by Martin Coutts
Martin Coutts
18,154 Points

Set target attribute

Can't seem to get this to work, sure there's a glaringly obvious answer but just can't seem to see it

js/app.js 
$( ".external a" ).add( "target", "_blank")
index.html 
<!DOCTYPE html>
<html>
<head>
  <link rel="stylesheet" href="css/style.css" type="text/css" media="screen" title="no title" charset="utf-8">
  <title>Links Page</title>
</head>
<body>
  <h1>Links</h1>
  <ul>
    <li><a href="http://google.com" class="external">Google</a></li>
    <li><a href="http://yahoo.com" class="external">Yahoo</a></li>
  </ul>
  <script src="//code.jquery.com/jquery-1.11.0.min.js" type="text/javascript" charset="utf-8"></script>
  <script src="js/app.js" type="text/javascript" charset="utf-8"></script>
</body>
</html>

1 Answer

Steven Parker
Steven Parker
231,275 Points
Steven Parker
Steven Parker
231,275 Points

I see two issues:

  • the jQuery method to add an attribute is ".attr" (not ".add")
  • ".external a" targets links descendant from an element with the class "external", but the challenge asked for links with the class "external" ("a.external")
Martin Coutts
Martin Coutts
18,154 Points
Martin Coutts
Martin Coutts
18,154 Points

Thanks for the help Steven