Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript Basics (Retired) Creating Reusable Code with Functions Create a max() Function

Posted by Lewis Long
Lewis Long
2,823 Points

[SOLVED] why wont this work?

function max(num1, num2) { if(num1 > num2) { alert(num1 + ' is the greater number'); }else if(num1 < num2) { alert (num2 + ' is the greater number'); } return (num1, num2); } alert( max(1, 2) );

script.js 
function max(num1, num2) {
  if(num1 > num2) {
    alert(num1 + ' is the greater number');
  }else if(num1 < num2) {
    alert (num2 + ' is the greater number');
  }
  return (num1, num2);
}
alert(max(1, 2));

1 Answer

jcorum
jcorum
71,830 Points
jcorum
jcorum
71,830 Points

Basically because you were supposed to return only one number: the one that was the largest. Also, you don't need the alerts in the body of the function:

function max(num1, num2) {
  if(num1 > num2) {
    return num1;
  }else {
    return num2;
  }
}
alert(max(1, 2));