Welcome to the Treehouse Community
Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.
Looking to learn something new?
Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.
Start your free trial
Troy Childs
Courses Plus Student 5,203 Pointsstill stuck on this Java challenge
HELP!!! not really sure what im doing wrong here, im on part 2 of this Java challenge. here is the code that i have.
private String normalizeDiscountCode(String discountCode){
for (char discode : discountCode.toCharArray()){
char ch = '$';
boolean dollarSign = discountCode.indexOf(ch) != -1;
if(! Character.isLetter(discode) || dollarSign){
throw new IllegalArgumentException("Invalid discount code");
}
}
return discountCode.toUpperCase();
}
public class Order {
private String itemName;
private int priceInCents;
private String discountCode;
public Order(String itemName, int priceInCents) {
this.itemName = itemName;
this.priceInCents = priceInCents;
}
public String getItemName() {
return itemName;
}
public int getPriceInCents() {
return priceInCents;
}
public String getDiscountCode() {
return discountCode;
}
public void applyDiscountCode(String discountCode) {
this.discountCode = normalizeDiscountCode(discountCode);
}
private String normalizeDiscountCode(String discountCode){
for (char discode : discountCode.toCharArray()){
char ch = '$';
boolean dollarSign = discountCode.indexOf(ch) != -1;
if(! Character.isLetter(discode) || dollarSign){
throw new IllegalArgumentException("Invalid discount code");
}
}
return discountCode.toUpperCase();
}
}
public class Example {
public static void main(String[] args) {
// This is here just for example use cases.
Order order = new Order(
"Yoda PEZ Dispenser",
600);
// These are valid. They are letters and the $ character only
order.applyDiscountCode("abc");
order.getDiscountCode(); // ABC
order.applyDiscountCode("$ale");
order.getDiscountCode(); // $ALE
try {
// This will throw an exception because it contains numbers
order.applyDiscountCode("ABC123");
} catch (IllegalArgumentException iae) {
System.out.println(iae.getMessage()); // Prints "Invalid discount code"
}
try {
// This will throw as well, because it contains a symbol.
order.applyDiscountCode("w@w");
}catch (IllegalArgumentException iae) {
System.out.println(iae.getMessage()); // Prints "Invalid discount code"
}
}
}
4 Answers
Jason Thomas
12,519 Points//yeah the condition in the if is still messed up. try a nested if like this
private String normalizeDiscountCode(String discountCode){
for (int i = 0; i < discountCode.length(); i++){
Character ch = discountCode.charAt(i);
if (!Character.isLetter(ch)){
if(ch != '$') {
throw new IllegalArgumentException("Invalid discount code");
}
}
}
return discountCode.toUpperCase();
} }
Jason Thomas
12,519 Points// I think this will work, or something very close to it will.
private String normalizeDiscountCode(String discountCode){
for (int i = 0; i < discountCode.length(); i++){
Character ch = discountCode.charAt(i);
if (!Character.isLetter(ch) || ch != '$'){
throw new IllegalArgumentException("Invalid discount code");
}
}
return discountCode.toUpperCase();
}
Troy Childs
Courses Plus Student 5,203 Pointsthat does not seem to be working. but thanks for you help
Troy Childs
Courses Plus Student 5,203 PointsHey it WORKS!!!! thanks for your help with this.
Jason Thomas
12,519 PointsNo problem, glad I could help.