Welcome to the Treehouse Community
Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.
Looking to learn something new?
Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.
Start your free trialElle Inad
568 PointsStuck on fun fact number 1
Unfortunately, the fun fact is not updated on button press. I can't see any compile errors either. What's wrong? Below is my code :
package com.dariusus.funfacts;
import android.support.v7.app.ActionBarActivity; import android.os.Bundle; import android.view.Menu; import android.view.MenuItem; import android.view.View; import android.widget.Button; import android.widget.TextView;
import java.util.Random;
public class FunFactsActivity extends ActionBarActivity {
@Override
protected void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
setContentView(R.layout.activity_fun_facts);
// Declare our View variables and asign the views from the layout file
final TextView factLabel = (TextView) findViewById(R.id.factTextView);
Button showFactButton = (Button) findViewById(R.id.showFactButton);
View.OnClickListener listener = new View.OnClickListener() {
@Override
public void onClick(View v) {
// The button was clicked, so update the fact label with a new fact
String fact = "";
//Randomly select a fact
Random randomGenerator = new Random(); // Construct a new random number generator
int randomNumber = randomGenerator.nextInt(3);
fact = randomNumber + ""; // this converts randomNumber into a string :)
/* Convert the randomNumber into a text fact
* 0 = Ants stretch when they wake up in them morning
* 1 = Ostriches can run faster than horses
* 2 = Olympic gold medals are actually made mostly of silver.
*/
// if random number is equal to zero
if (randomNumber == 0){
// set fact to ants fact
fact = "Ants stretch when they wake up in the morning";
}
else if (randomNumber == 1){
// set fact to Ostriches fact
fact = "Ostriches can run faster than horses";
}
else if (randomNumber == 2){
// set fact to gold fact
fact = "Olympic gold medals are actually made mostly of silver.";
}
else {
fact = "oops, something went wrong here";
}
}
};
showFactButton.setOnClickListener(listener);
}
@Override
public boolean onCreateOptionsMenu(Menu menu) {
// Inflate the menu; this adds items to the action bar if it is present.
getMenuInflater().inflate(R.menu.menu_fun_facts, menu);
return true;
}
@Override
public boolean onOptionsItemSelected(MenuItem item) {
// Handle action bar item clicks here. The action bar will
// automatically handle clicks on the Home/Up button, so long
// as you specify a parent activity in AndroidManifest.xml.
int id = item.getItemId();
//noinspection SimplifiableIfStatement
if (id == R.id.action_settings) {
return true;
}
return super.onOptionsItemSelected(item);
}
}
1 Answer
Jon Kussmann
Courses Plus Student 7,254 PointsHi Elle,
You are pretty close. There is just one more thing to do. After you if-statements you need to set that fact to the TextView that displays your facts.
factLabel.setText(fact);
Elle Inad
568 PointsElle Inad
568 PointsThank you , Jon :)