Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Java Java Objects Delivering the MVP Applying a Discount Code

Jacob Gonzales
Jacob Gonzales
1,837 Points

Task 1 is no longer working?

I am trying to normalize the discount code, but if it is not a letter or $ then it should throw an exception. If it contains letters or the symbol $ it should return the uppercase version of the string in getDiscountCode. After adding the section in normalizeDiscountCode that checks each char it no longer return the uppercase version?

Order.java
public class Order {
  private String itemName;
  private int priceInCents;
  private String discountCode;


  private String normalizeDiscountCode(String discountCode) {
    for(char c : discountCode.toCharArray()) {
      if(c != '$' || !Character.isLetter(c)){
        throw new IllegalArgumentException("Invalid discount code");
      }
    }
    return discountCode.toUpperCase();
  }

  public Order(String itemName, int priceInCents) {
    this.itemName = itemName;
    this.priceInCents = priceInCents;
  }

  public String getItemName() {
    return itemName;
  }

  public int getPriceInCents() {
    return priceInCents;
  }

  public String getDiscountCode() {
    return discountCode;
  }

  public void applyDiscountCode(String discountCode) {
    try {
      this.discountCode = this.normalizeDiscountCode(discountCode);
    } catch(IllegalArgumentException iae) {
      System.out.println(iae.getMessage());
    } 
  }

}
Example.java
public class Example {

  public static void main(String[] args) {
    // This is here just for example use cases.

    Order order = new Order(
            "Yoda PEZ Dispenser",
            600);

    // These are valid.  They are letters and the $ character only
    order.applyDiscountCode("abc");
    order.getDiscountCode(); // ABC

    order.applyDiscountCode("$ale");
    order.getDiscountCode(); // $ALE


    try {
      // This will throw an exception because it contains numbers
      order.applyDiscountCode("ABC123");
    } catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }
    try {
      // This will throw as well, because it contains a symbol.
      order.applyDiscountCode("w@w");
    }catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }

  }
}

1 Answer

Mihai Craciun
Mihai Craciun
13,520 Points

You are so close! Think about the task you have to throw the exception if the code does not contain letter AND the '$' is an exception. In this case all you have to do is replace || (OR symbol) with && (AND symbol) in your if statement and it should work :). Happy coding!

Mihai Craciun
Mihai Craciun
13,520 Points

You're welcome :)! I'm glad I could help!

Jacob Gonzales
Jacob Gonzales
1,837 Points

I figured it out! You were right I needed to change my or with and, but the challenge did not want me to put the applyDiscountCode with a try catch it just wanted it to throw the exception for some reason. Either way it works so thanks again!