Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript jQuery Basics (2014) Creating a Simple Lightbox Adding New Attribute Values with attr()

Posted by nagamani palamuthi
nagamani palamuthi
6,160 Points

this challenge is not passing...

$(".external a").attr("target" , " _blank");

could someone chk my code?

js/app.js 
$(".external a").attr("target" , " _blank");
index.html 
<!DOCTYPE html>
<html>
<head>
  <link rel="stylesheet" href="css/style.css" type="text/css" media="screen" title="no title" charset="utf-8">
  <title>Links Page</title>
</head>
<body>
  <h1>Links</h1>
  <ul>
    <li><a href="http://google.com" class="external">Google</a></li>
    <li><a href="http://yahoo.com" class="external">Yahoo</a></li>
  </ul>
  <script src="//code.jquery.com/jquery-1.11.0.min.js" type="text/javascript" charset="utf-8"></script>
  <script src="js/app.js" type="text/javascript" charset="utf-8"></script>
</body>
</html>

1 Answer

Amir Eskandari
Amir Eskandari
9,153 Points
Amir Eskandari
Amir Eskandari
9,153 Points

Hi nagamani,

I think you just have a little bit too much information in your statement - just using "a" should be sufficient, like so:

$("a")....

Also be careful of extra spaces - they will throw off your code.

Let me know if you need more help!

nagamani palamuthi
nagamani palamuthi
6,160 Points

thanks! it passed after I fixed the spaces.