View.OnClickListener Outside the onCreate method

Question

I wrote the View.OnClickListener like this:

package sahar.funfacts;

import...

public class FunFactsActivity extends AppCompatActivity {

    // Declare our View variables
    private TextView mFactTextView;
    private Button mShowFactButton;

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_fun_facts);

        // Assign the Views from thel layout file to the corresponding variables
        mFactTextView = (TextView)findViewById(R.id.factTextView);
        mShowFactButton = (Button)findViewById(R.id.showFactButton);


        mShowFactButton.setOnClickListener(listener);
    }

    View.OnClickListener listener = new View.OnClickListener() {
        @Override
        public void onClick(View v) {

        }
    };
}

Is this a problem to write this method outside the OnCreate method? Why did he write it there?

Answer 1 · 2016-10-08T19:00:54Z

October 8, 2016 7:00pm

Either way works. Here it's being stored in a field. That can be useful if a reference to the listener is needed later, but not necessary.

There are several other styles of dealing with the listener as well, each of which isn't inherently better than the others.

Welcome to the Treehouse Community

Looking to learn something new?

Sahar Nasiri

Sahar Nasiri

View.OnClickListener Outside the onCreate method

1 Answer

Seth Kroger

Seth Kroger