Welcome to the Treehouse Community

The Treehouse Community is a meeting place for developers, designers, and programmers of all backgrounds and skill levels to get support. Collaborate here on code errors or bugs that you need feedback on, or asking for an extra set of eyes on your latest project. Join thousands of Treehouse students and alumni in the community today. (Note: Only Treehouse students can comment or ask questions, but non-students are welcome to browse our conversations.)

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and a supportive community. Start your free trial today.

Python Django Basics Final Details Article detail view

Want to make sure we handle bad pks when looking up our Articles. Use get_object_or_404 to look up the Article.

I error I am getting is "Make sure bad PKs return 404"

articles/views.py
from django.shortcuts import render
from django.shortcuts import get_object_or_404
from .models import Article, Writer


def article_list(request):
    articles = Article.objects.all()
    return render(request, 'articles/article_list.html', {'articles': articles})


def writer_detail(request, pk):
    writer = Writer.objects.get(pk=pk)
    article = get_object_or_404(Article, pk=pk)
    return render(request, 'articles/writer_detail.html', {'writer': writer})

def article_detail(request, pk):
    article = Article.objects.get(pk=pk) 
    article = get_object_or_404(Article, pk=pk) 
    return render(request, 'articles/article_detail.html',{'article': article})
articles/urls.py
from django.conf.urls import url


from . import views

urlpatterns = [
    url(r'writer/(?P<pk>\d+)/$', views.writer_detail),
     url(r'article/(?P<pk>\d+)/$', views.article_detail),
    url(r'', views.article_list),
]

1 Answer

Your code seems fine but you need to remove this line:

  article = Article.objects.get(pk=pk) 

You don't need it because you are reassigning the variable article the line below using the 404 method.

I assume that the call to objects.get is causing some problems during the challenge validation.