Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript jQuery Basics (2014) Creating a Simple Lightbox Adding New Attribute Values with attr()

Monica McCready
Monica McCready
6,043 Points
Posted by Monica McCready
Monica McCready
6,043 Points

What am I doing wrong?

Here's my answer:

var _blank = $(this).attr('href');

$("#external").attr("href","_blank");

js/app.js 
var _blank = $(this).attr('href');

$("#external").attr("href","_blank");
index.html 
<!DOCTYPE html>
<html>
<head>
  <link rel="stylesheet" href="css/style.css" type="text/css" media="screen" title="no title" charset="utf-8">
  <title>Links Page</title>
</head>
<body>
  <h1>Links</h1>
  <ul>
    <li><a href="http://google.com" class="external">Google</a></li>
    <li><a href="http://yahoo.com" class="external">Yahoo</a></li>
  </ul>
  <script src="//code.jquery.com/jquery-1.11.0.min.js" type="text/javascript" charset="utf-8"></script>
  <script src="js/app.js" type="text/javascript" charset="utf-8"></script>
</body>
</html>

2 Answers

Jason Berteotti
Jason Berteotti
12,352 Points
Jason Berteotti
Jason Berteotti
12,352 Points

You are changing the incorrect attribute, and you are targeting an id, not a class.

vryiziilos
seal-mask
.a{fill-rule:evenodd;}techdegree
vryiziilos
Full Stack JavaScript Techdegree Student 23,052 Points
vryiziilos
.a{fill-rule:evenodd;}techdegree
vryiziilos
Full Stack JavaScript Techdegree Student 23,052 Points

Also I believe that _blank should not be enclosed in quotes when assigning new attribute.