Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript jQuery Basics (2014) Creating a Simple Lightbox Adding New Attribute Values with attr()

MUSTAFA DIRIK
MUSTAFA DIRIK
15,023 Points
Posted by MUSTAFA DIRIK
MUSTAFA DIRIK
15,023 Points

what is wrong with my code?

I couldnt pass this challenge.. anyone could help?

js/app.js 
$("#external a").attr("target", _blank);
index.html 
<!DOCTYPE html>
<html>
<head>
  <link rel="stylesheet" href="css/style.css" type="text/css" media="screen" title="no title" charset="utf-8">
  <title>Links Page</title>
</head>
<body>
  <h1>Links</h1>
  <ul>
    <li><a href="http://google.com" class="external">Google</a></li>
    <li><a href="http://yahoo.com" class="external">Yahoo</a></li>
  </ul>
  <script src="//code.jquery.com/jquery-1.11.0.min.js" type="text/javascript" charset="utf-8"></script>
  <script src="js/app.js" type="text/javascript" charset="utf-8"></script>
</body>
</html>

1 Answer

Jennifer Nordell
seal-mask
STAFF
.a{fill-rule:evenodd;}techdegree
Jennifer Nordell
Treehouse Teacher
Jennifer Nordell
.a{fill-rule:evenodd;}techdegree
Jennifer Nordell
Treehouse Teacher

Hi there! There are couple of things going on here. First you're selecting all anchor tags inside of anything that has the id of "external" instead of all anchor tags with the id "external". It's a subtle, but important difference. Secondly, the "_blank" should be in quotation marks as it's a string to be passed in and not a variable.

Take a look:

$("a.external").attr("target", "_blank");

Take a moment to review what this line of code is doing. Hope this helps! :sparkles:

MUSTAFA DIRIK
MUSTAFA DIRIK
15,023 Points
MUSTAFA DIRIK
MUSTAFA DIRIK
15,023 Points

Thank you soo much for you help and explanation.