Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python Python Collections (2016, retired 2019) Lists Shopping List Take Three

while loop does not work - why?

import os

shopping_list = []

def clear_screen(): os.system("cls" if os.name == "nt" else "clear")

def show_help(): clear_screen() print("What should we pick up at the store?") print(""" Enter 'DONE' to stop adding items. Enter 'HELP' for this help. Enter 'SHOW' to see your current list. """)

def add_to_list(item): show_list() if len(shopping_list): position = input("Where should I add {}?\n" "Press ENTER to add to the end of the list\n" "> ".format(item)) else: position = 0

try:
    position = abs(int(position))
except ValueError:
    position = None
if position is not None:
    shopping_list.insert(position-1, item)
else:
    shopping_list.append(new_item)

show_list()

def show_list(): clear_screen()

print("Here's your list:")

index = 1
for item in shopping_list:
    print("{}. {}".format(index, item))
    index +=1
print("-"*10)

show_help()

while True: new_item = input("> ")

if new_item.upper == 'DONE' or new_item.upper == 'QUIT':
    break
elif new_item.upper == 'HELP':
    show_help()
    continue
elif new_item.upper == 'SHOW':
    show_list()
    continue
else:
    add_to_list(new_item)

show_list()

When I type any of the words (done/quit/help/show), it prompts me to add this value to the list. Why? Where is the mistake?

1 Answer

Hi Maiia Spivak,

Try calling the upper function.

You need to add those pesky parentheses to the upper function, like this: new_item.upper()

And yes, you need to do that in all places where you didn't use parentheses with .upper

Hope this helps!

~Alex

Thank you for a quick response! That helped :)

No problem :)

(btw I'm an alien :alien: lol #JK)