Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript and the DOM (Retiring) Getting a Handle on the DOM Practice Selecting Elements

Henri Okajima
Henri Okajima
6,995 Points
Posted by Henri Okajima
Henri Okajima
6,995 Points

Why my <li> selection code is wrong?

Hello, I've tried the following code:

let navigationLinks = document.querySelector('nav').querySelectorAll('li');

and it runs well in my browser, returning: NodeList [ <li>, <li>, <li> ]

Why it could not be a solution?

Thanks

js/app.js 
let navigationLinks = document.querySelector('nav').querySelectorAll('li');
let galleryLinks;
let footerImages;
index.html 
<!DOCTYPE html>
<html>
  <head>
    <meta charset="utf-8">
    <title>Nick Pettit | Designer</title>
    <link rel="stylesheet" href="css/normalize.css">
    <link href='http://fonts.googleapis.com/css?family=Changa+One|Open+Sans:400italic,700italic,400,700,800' rel='stylesheet' type='text/css'>
    <link rel="stylesheet" href="css/main.css">
    <link rel="stylesheet" href="css/responsive.css">
    <meta name="viewport" content="width=device-width, initial-scale=1.0">
  </head>
  <body>
    <header>
      <a href="index.html" id="logo">
        <h1>Nick Pettit</h1>
        <h2>Designer</h2>
      </a>
      <nav>
        <ul>
          <li><a href="index.html" class="selected">Portfolio</a></li>
          <li><a href="about.html">About</a></li>
          <li><a href="contact.html">Contact</a></li>
        </ul>
      </nav>
    </header>
    <div id="wrapper">
      <section>
        <ul id="gallery">
          <li>
            <a href="img/numbers-01.jpg">
              <img src="img/numbers-01.jpg" alt="">
              <p>Experimentation with color and texture.</p>
            </a>
          </li>
          <li>
            <a href="img/numbers-02.jpg">
              <img src="img/numbers-02.jpg" alt="">
              <p>Playing with blending modes in Photoshop.</p>
            </a>
          </li>
        </ul>
      </section>
      <footer>
        <a href="http://twitter.com/nickrp"><img src="img/twitter-wrap.png" alt="Twitter Logo" class="social-icon"></a>
        <a href="http://facebook.com/nickpettit"><img src="img/facebook-wrap.png" alt="Facebook Logo" class="social-icon"></a>
        <p>&copy; 2016 Nick Pettit.</p>
      </footer>
    </div>
  <script src="js/app.js"></script>
  </body>
</html>
Henri Okajima
Henri Okajima
6,995 Points
Henri Okajima
Henri Okajima
6,995 Points

... The problem is that I made a mistake betwen <li> and <a>. Everything would be better if I had written:

let navigationLinks = document.querySelector('nav').querySelectorAll('a');

1 Answer

Steven Parker
Steven Parker
231,269 Points
Steven Parker
Steven Parker
231,269 Points

The challenge instructions say to "select all links in the nav element". Links are represented by anchor ("a") elements. An "li" element is a list item.

Fixing that will pass the challenge, but if you want, you can make the code more compact by using a single querySelectorAll call with a descendant selector as the argument, where you name both the ancestor and the target elements separated by a space.

Henri Okajima
Henri Okajima
6,995 Points
Henri Okajima
Henri Okajima
6,995 Points

Thanks for the tips!