checking values code challenge task one

Question

Hi, I know the correct answer for this code challenge from searching the forum, but I don't understand why it is the correct answer and what is wrong with my attempt.

The question is: Create a method called 'isValidEmail' that takes one argument that returns true when a string with an '@' symbol is passed, false if not.

The correct answer is:

function isValidEmail (email) {
     return email.indexOf("@") != -1;
}

If I was to use my own logic rather than copying and pasting the correct answer, this is what I would end up with:

function isValidEmail (email) {
    if (email.indexOf("@") != -1;) {
     return true;
     } else {
     return false;
     }
}

Can anyone please explain to me what is wrong with my logic here? I don't understand how the correct answer can be correct without using return true, return false, and if and else.

Answer 1 · 2014-02-02T04:03:20Z

February 2, 2014 4:03am

Hi Jenny, i think both functions will end up in the same result, the only thing that changes is the number of lines you use for achieving the test.

If you think about it, when javascript test <email.indexOf("@") != -1;> the possible values that we will have are a -1 which is considered false, or a positive number which is considered true.

In the other case, the code will first test the expression with the if statement (the if statement tests either a true or a false value) and then if it is true then you explicitly are returning a true, if not then explicitly you return a false value.

I hope that will answer your question.

Welcome to the Treehouse Community

Looking to learn something new?

Jenny Swift

Jenny Swift

checking values code challenge task one

1 Answer

Juan Jose Cortes Guzman

Juan Jose Cortes Guzman

Jenny Swift

Jenny Swift