Error on return new InboxFragment();

Question

At the 6 minute mark in the Modifying Fragments from the Template video, when changing the getItem method of the SectionsPagerAdapter file, an error appears when changing from return fragment to return new InboxFragment();

The error reads "Type mismatch: cannot convert from InboxFragment to Fragment"

I've tried sorting imports and cleaning the project.

Here is InboxFragment.java

package com.stryffeler.ribbit;

import android.os.Bundle; import android.support.v4.app.ListFragment; import android.view.LayoutInflater; import android.view.View; import android.view.ViewGroup;

public class InboxFragment extends ListFragment { @Override public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) { View rootView = inflater.inflate(R.layout.fragment_inbox, container, false); return rootView; } }

Here is fragment_inbox.xml

<ListView
    android:id="@android:id/list"
    android:layout_width="match_parent"
    android:layout_height="match_parent"
    android:layout_alignParentLeft="true"
    android:layout_alignParentTop="true" >

</ListView>

<TextView
    android:id="@android:id/empty"
    android:layout_width="match_parent"
    android:layout_height="wrap_content"
    android:text="@string/empty_inbox_label" />

</RelativeLayout>

and here is SectionsPagerAdapter.java

package com.stryffeler.ribbit;

import java.util.Locale;

import android.app.Fragment; import android.app.FragmentManager; import android.content.Context; import android.support.v13.app.FragmentPagerAdapter;

/**

A {@link FragmentPagerAdapter} that returns a fragment corresponding to
one of the sections/tabs/pages. */ public class SectionsPagerAdapter extends FragmentPagerAdapter {

protected Context mContext;

public SectionsPagerAdapter(Context context, FragmentManager fm) { super(fm); mContext = context; }

@Override public Fragment getItem(int position) { // getItem is called to instantiate the fragment for the given page. // Return a PlaceholderFragment (defined as a static inner class below).
```
return new InboxFragment();
```
}

@Override public int getCount() { return 2; }

@Override public CharSequence getPageTitle(int position) { Locale l = Locale.getDefault(); switch (position) { case 0: return mContext.getString(R.string.title_section1).toUpperCase(l); case 1: return mContext.getString(R.string.title_section2).toUpperCase(l); } return null; } }

Thanks for your help!

Answer 1 · 2014-04-22T18:44:55Z

April 22, 2014 6:44pm

I found this post in forum: https://teamtreehouse.com/forum/android-studio-return-new-inboxfragment

Check john appleby's comment starting "After trailing,,,,,". I'm currently building this app by creating the project from "File>New". And I found the default MainActivity.java inherites from:i.e. extends "Activity" not "FragmentActivity". I have a feeling I saw this correction in the video, but in my case I had forgot to do it, so I let you guys know here.

Answer 2 · 2014-06-10T04:57:00Z

June 10, 2014 4:57am

Ok.. I finally figured out my issue. It was a few things so I will explain in case someone else runs into this issue. In my imports I was importing some v4 and some v13, they all need to match in every file in the project as they do not play nice together. Once I had that solved it fixed my issue but created another.. which was the error "The constructor FragmentPagerAdapter(FragmentManager) is undefined" which can be fixed by going back to MainActivity and changing the "mSectionsPagerAdapter = new SectionsPagerAdapter(this, getFragmentManager());" line to: " FragmentManager fragmentManager = getSupportFragmentManager(); mSectionsPagerAdapter = new SectionsPagerAdapter(this, fragmentManager); " and then organize your imports. Hopefully this helps someone because I was definitely stuck for a few days on this one!

Answer 3 · 2014-08-06T16:41:34Z

August 6, 2014 4:41pm

Martin Stryffeler

I solved this problem as follows: The PlaceholderFragment class was removed from class MainActivity exactly the same way as the class SectionsPagerAdapter was removed from MainActivity class. The PlaceholderFragment class extends FragmentPagerAdapter. This not changed nothing but it is best for understand the code.

The SectionsPagerAdapter extends FragmentPagerAdapter. These are the imports need in this class: import android.support.v4.app.FragmentManager; import android.support.v4.app.FragmentPagerAdapter; import android.support.v4.app.ListFragment;.

The MainActivity should extends the FragmentActivity class , not Activity class. These imports from v4 support libraries are needed to this code : import android.support.v4.app.FragmentActivity; import android.support.v4.app.FragmentPagerAdapter; import android.support.v4.view.ViewPager;.

Please verify if there some v13 or v7 support imports and remove them.

I think that this can help you now.

Answer 4 · 2014-04-18T06:12:57Z

April 18, 2014 6:12am

add support.v4. before the app..... in the imports. Example: import android.support.v4.app.FragmentPagerAdapter;

Answer 5 · 2014-04-18T22:21:10Z

April 18, 2014 10:21pm

on line 64, mSectionsPagerAdapter = new SectionsPagerAdapter(this, getFragmentManager()) change it to on line 64, mSectionsPagerAdapter = new SectionsPagerAdapter(this, getSupportFragmentManager())

Answer 6 · 2014-06-08T00:17:13Z

June 8, 2014 12:17am

Were you able to fix this? I am stuck on the same step. "The return type is incompatible with FragmentPagerAdapter.getItem(int)"

@Override public ListFragment getItem(int position) { // getItem is called to instantiate the fragment for the given page. // Return a PlaceholderFragment (defined as a static inner class below).

return new InboxFragment();

}

Answer 7 · 2014-06-10T04:14:27Z

June 10, 2014 4:14am

I am still stuck on this.. anyone find a solution?!

Answer 8 · 2014-09-07T18:34:39Z

September 7, 2014 6:34pm

Thank you Martin Stryffeler Your solution solved the issue for me.

Answer 9 · 2014-04-18T01:13:56Z

April 18, 2014 1:13am

Since InboxFragment extends ListFragment, not Fragment, I believe the solution is to change the return type of the getItem(int position) method in SectionsPagerAdapter from Fragment to ListFragment.

@Override
public ListFragment getItem(int position) {
    // getItem is called to instantiate the fragment for the given page.
    // Return a PlaceholderFragment (defined as a static inner class below).

    return new InboxFragment();
}

Welcome to the Treehouse Community

Looking to learn something new?

Martin Stryffeler

Martin Stryffeler

Error on return new InboxFragment();

9 Answers

Hiroki Hokari

Hiroki Hokari

Martin Stryffeler

Martin Stryffeler

Erin Kabbash

Erin Kabbash

Rodrigo Rocha

Rodrigo Rocha

Karan Ghai

Karan Ghai

Martin Stryffeler

Martin Stryffeler

Karan Ghai

Karan Ghai

Martin Stryffeler

Martin Stryffeler

Erin Kabbash

Erin Kabbash

Erin Kabbash

Erin Kabbash

Alex Perea

Alex Perea

Christopher Hall

Christopher Hall

Martin Stryffeler

Martin Stryffeler