JavaScript Methods help: "On 'andrew' and 'ryan', set the 'greet' method as the 'genericGreet' function".

you're almost there bud. Here's what it should look like:

<script>
    var genericGreet = function() {
        return "Hello, my name is " + this.name;
    }

    var andrew = {
        name: "Andrew",
        greet: genericGreet
    }

    var ryan = {
        name: "Ryan",
        greet: genericGreet
    }
</script>

Alright, so what are we doing differently here? Well, first just some basic syntax errors right away. You'll notice that there needs to be a comma separating the methods name and greet and no semicolon is needed after the last method, in this case, greet.

So what else? Well, the parameter that you have set for the genericGreet function, person, is not needed. Why? Well, when we call either andrew or ryan's greet method, we use the this keyword inside the genericGreet function so that we know that we are calling the name method from within the correct scope.

The other key thing that you're missing here is how you're calling genericGreet. Right now you are calling genericGreet like a method, however it is a function. So what you need to do is set the greet method to genericGreet, as I did above, so that when you call either andrew.greet or ryan.greet it will call the genericGreet function and correctly display the correct string.

Hope I wasn't too confusing!

The video on methods is pretty complicated, but the challenge is more simple, in a way. That can be confusing sometimes. Thanks for the answers!

You're awesome Aaron Cochran . I've never touched JavaScript in my life pre-TeamTreehouse...so this is all very new to me. I'm absorbing it all slowly! Thanks buddy

Aaron Cochran so I just tried the code you gave me and it didn't work

Thanks Aaron Cochran, my only mistake was adding the parentheses calling the genericGreet function. So i had

greet : genericGreet()

I'm still a bit confused - I thought when we called a function, we needed the parentheses e.g.

jimGreet();

Why are the parentheses not needed when calling the genericGreet function within the Andrew / Ryan objects??

I think I have a answer! genericGreeting is actually a variable that contains a fucntion, not a function in itself, therefore we only need to call the variable, which doesn't need the parentheses. Sound right?

var genericGreet = function() { return "Hello, my name is " + this.name; }

var andrew = { name: "Andrew", greet: genericGreet }

var ryan = { name: "Ryan", greet: genericGreet }

My error was missing the commas separating the methods name and greet. Thanks for the explanation after your answer too.

Thanks guys, this helped me too.

Awesome Aaron I thank you for helping me to understand without just giving me the answer!!! Treehouse, this such a great idea to use, that'll help teach us! The whole here is the answer without giving the answer.

I'm not sure why, but it wouldn't work until I did this (adding the "this" to genericGreet):

<script>
    var genericGreet = function() {
        return "Hello, my name is " + this.name;
    }

    var andrew = {
        name: "Andrew",
        greet: this.genericGreet
    }

    var ryan = {
        name: "Ryan",
        greet: this.genericGreet
    }
</script>