Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Android Implementing Designs for Android Customizing the Login Screen Customizing Buttons

Posted by MUZ140820 Immaculate Ncube
MUZ140820 Immaculate Ncube
4,611 Points

A bit confused on how to change a default button background color

pleas help

activity_main.xml 
<RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"
    android:layout_width="match_parent"
    android:layout_height="match_parent" >

    <Button
        android:id="@+id/saveButton"
        android:layout_width="match_parent"
        android:layout_height="wrap_content"
        android:layout_centerInParent="true"
        android:text="@string/save_label" 
            android:background="@drawable/button_custom"/>

</RelativeLayout>
button_custom.xml 
<?xml version="1.0" encoding="utf-8"?>
<selector xmlns:android="http://schemas.android.com/apk/res/android" >

    <item
        android:drawable="@android:color/darker_gray"
        android:state_pressed="true"/>
    <item
        android:drawable="@android:color/holo_blue_light"
        android:state_focused="true"/>

    <item android:drawable="@android:color/holo_red_light"
          android:background="@android:color/white"/>

</selector>

2 Answers

Kristian Terziev
Kristian Terziev
28,449 Points
Kristian Terziev
Kristian Terziev
28,449 Points

Well since you're not told in which state you should change the color, it's logical to do it in it's normal state. Meaning you've oriented right, but you didn't write the right code. It's not as complex as you think. You should just change this:

<item android:drawable="@android:color/holo_red_light" />

to this

<item android:drawable="@android:color/white" />
Mark Filter
Mark Filter
32,718 Points
Mark Filter
Mark Filter
32,718 Points

You should not change the background color of a button directly by accessing the following property:

android:background

Doing so, you will lose any user interactive animations that come standard in API 21+. For complete compatibility and to maintain Material Design animations in buttons, target the following property:

android:backgroundTint