Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript jQuery Basics (2014) Creating a Simple Lightbox Adding New Attribute Values with attr()

Posted by OLUBUKOLA OGUNSOLA
.a{fill-rule:evenodd;}techdegree seal-36
OLUBUKOLA OGUNSOLA
Full Stack JavaScript Techdegree Graduate 30,442 Points

adding attribute

while is my code not working here? ive tried several stuff including $("#external a").attr('target', _blank);

please help

js/app.js 
 $("#external a").attr('target', "_blank");
index.html 
<!DOCTYPE html>
<html>
<head>
  <link rel="stylesheet" href="css/style.css" type="text/css" media="screen" title="no title" charset="utf-8">
  <title>Links Page</title>
</head>
<body>
  <h1>Links</h1>
  <ul>
    <li><a href="http://google.com" class="external">Google</a></li>
    <li><a href="http://yahoo.com" class="external">Yahoo</a></li>
  </ul>
  <script src="//code.jquery.com/jquery-1.11.0.min.js" type="text/javascript" charset="utf-8"></script>
  <script src="js/app.js" type="text/javascript" charset="utf-8"></script>
</body>
</html>

1 Answer

Jason Cook
Jason Cook
11,403 Points
Jason Cook
Jason Cook
11,403 Points

Hi, the problem is that your jQuery is targeting an ID rather than a class, which is what "external" is. Here's how you resolve this issue (see before fix and after fix examples below).

Before Fix (incorrectly targeting an ID that doesn't exist)

   $("#external a").attr('target', "_blank");

After Fix (targets the class .external instead of ID #external)

   $('.external').attr('target', '_blank');

Now, after reloading, you'll notice that clicking on one of the external links will open in a new tab.

I hope this helps! Happy coding :-)

OLUBUKOLA OGUNSOLA
.a{fill-rule:evenodd;}techdegree seal-36
OLUBUKOLA OGUNSOLA
Full Stack JavaScript Techdegree Graduate 30,442 Points

thanks a lot, ive been dogmatically fowwing the id case used in the lecture videos