Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript Build a Simple Dynamic Site with Node.js Creating a Basic Template Engine in Node.js A Simple Merge Utility

Kenneth Kelley
Kenneth Kelley
12,276 Points
Posted by Kenneth Kelley
Kenneth Kelley
12,276 Points

Am I missing something in the challenge. I thought I provided the corrected answer and it is not accepted.

Here is what was provided:

function merge(content, values) { content = content.replace('%first_name%', values.first_name); return content; }

module.exports.merge = merge;

index.js 
var utilities = require("./utilities");

var mailValues = {};

mailValues.first_name = "Janet";

var emailTemplate = "Hi %first_name%! Thanks for completing this code challenge :)";

var mergedContent = utilities.merge(emailTemplate, mailValues);

//mergedContent === "Hi Janet! Thanks for completing this code challenge :)";
utilities.js 
function merge(content, values) {
    content = content.replace('%first_name%', values.first_name);
  return content;
}


module.exports.merge = merge;

2 Answers

Balazs Peak
Balazs Peak
46,160 Points
Balazs Peak
Balazs Peak
46,160 Points

The situation is a little bit more complicated.

You are demanded to implement a function which programmatically can replace any values in any situation.

There are many possible solutions, here is mine:

function merge(content, values) {
  for(var key in values)
  {
    var toReplace = "%" + key + "%";
    content = content.replace(toReplace, values[key]);
  }

  return content;
}
Kenneth Kelley
Kenneth Kelley
12,276 Points
Kenneth Kelley
Kenneth Kelley
12,276 Points

Thanks for the response Balazs. Wasn't sure what was requested. You helped clear it up,

I provided this solution that was accepted.

function merge(content, values) { for(var key in values) { content = content.replace('%' + key + '%', values[key]); } return content; }

module.exports.merge = merge;