JavaScript JavaScript Loops, Arrays and Objects Tracking Data Using Objects The Build an Object Challenge, Part 2

Martin Wiulsrød
Martin Wiulsrød
Front End Web Development Techdegree Graduate 16,314 Points

Any tips or pointers?

The amount of "AHA!" moments I had during this coding challenge was insane, what a great challenge! Previously in this tech-degree, I have posted my code and asked what improvements that can be done. I have gotten some really great responses which have helped me become a better programmer. I'm open to any criticism or pointers! Here is my code:

// define variables
var html = "";
var students = [
  {name : "Martin", track : "JavaScript", achievements : 5, points : 1005}, 
  {name : "Alex", track : "Java", achievements : 2, points : 25},
  {name : "Jonas", track : "C#", achievements : 10, points : 66},
  {name : "Hannah", track : "Python", achievements : 3, points : 22},
  {name : "Maria", track : "CSS", achievements : 2, points : 16784},    
];

// display objects from an array
function displayStudents (arr) {
  for (var i = 0; i < arr.length; i++) {
    for (var property in arr[i]) {  
      if (property === "name") {
        html += "<h2>" + capitalizeFirstLetter(property) + ": " + arr[i][property] + "</h2>";
      } else {
        html += capitalizeFirstLetter(property) + ": " + arr[i][property] + "<br>";
      }
    }
    html += "<br>";
  }
  return html;
}

// print out message
function print(message) {
  document.getElementById("output").innerHTML = message;
}

// capitalize first letter of a string
function capitalizeFirstLetter(string) {
  return string.charAt(0).toUpperCase() + string.slice(1);
}

// call functions
print(displayStudents(students));
Dave StSomeWhere
Dave StSomeWhere
19,786 Points

Here's what pops out to me (just my silliness of course):

  1. Get over reviewing working code, While code reviews are important and being a team player is critical - all code can be improved but think forward and spend a little less time looking back - As one guy in Cannonball Run said "What's behind me isn't important" 2, I'd stop using var and start using let and const.
  2. I would consider trying to figure out how to refactor displayStudents by trying to avoid nesting two for statements and then an if and then an else - anything deeper that 2 levels causes me to do a special review.
  3. Avoid useless/obvious comments - like define variables and call functions. What value are you providing to someone reading the code. Maybe something like Define global variables and Main Student Array Process start type stuff. You comment that you are displaying objects from an array, but it isn't a generic process, it is very specific and even called displayStudents(). So, it is really just a Student array function. Calling the parameter arr also doesn't help, since it is really the students array - why not call it studentsArray.
  4. Spend more time on your test plans and running your code - everything will continue to fall into place.

Have fun and be glad you understand how to loop an array and process indexes and your style will continue to develop.

Quit worrying so much, your code is fine - nicely done :thumbsup:

1 Answer

Martin Wiulsrød
Martin Wiulsrød
Front End Web Development Techdegree Graduate 16,314 Points

Thanks for your response 🍹 Dave 🌴 StSomeWhere! Definitely gonna clean up my comments and start using let and const forward. I totally agree with the refactoring of that overly complicated function, I'm gonna chew on that when I go to bed (but listen to the guy in Cannonball Run). I have not read a lot of other peoples code, and I'm not used to documenting it very well from before. I need to create some rules and do some more research on how to name and document my code in a better way.

Thank you very much for taking the time though!