Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript Loops Working with 'for' Loops The Refactor Challenge – Duplicate Code

Posted by Peter Huang
Peter Huang
5,427 Points

Any way I can make my code shorter?

Is there any way I can make it better?

let html = '';

const randomValue = () => Math.floor(Math.random() * 256);

const randomRGB = (value) => rgb( ${value()}, ${value()}, ${value()} );

for ( let i = 1; i <= 10; i++ ) { html += <div style="background-color: ${randomRGB(randomValue)}">${i}</div>; }

document.querySelector('main').innerHTML = html;

1 Answer

Steven Parker
Steven Parker
229,644 Points
Steven Parker
Steven Parker
229,644 Points

When posting code, always use Markdown formatting to preserve the code's appearance and retain special symbols (such as the ` accent mark).

But shorter isn't always "better". There's a value in having code that's easily readable, and over-optimizing and abbreviating can compromise that. This sample seems pretty concise as is, not much could be reduced and still have it easy to read.