Welcome to the Treehouse Community

The Treehouse Community is a meeting place for developers, designers, and programmers of all backgrounds and skill levels to get support. Collaborate here on code errors or bugs that you need feedback on, or asking for an extra set of eyes on your latest project. Join thousands of Treehouse students and alumni in the community today. (Note: Only Treehouse students can comment or ask questions, but non-students are welcome to browse our conversations.)

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and a supportive community. Start your free trial today.

JavaScript JavaScript Loops Working with 'for' Loops The Refactor Challenge – Duplicate Code

Peter Huang
Peter Huang
3,314 Points

Any way I can make my code shorter?

Is there any way I can make it better?

let html = '';

const randomValue = () => Math.floor(Math.random() * 256);

const randomRGB = (value) => rgb( ${value()}, ${value()}, ${value()} );

for ( let i = 1; i <= 10; i++ ) { html += <div style="background-color: ${randomRGB(randomValue)}">${i}</div>; }

document.querySelector('main').innerHTML = html;

1 Answer

Steven Parker
Steven Parker
218,487 Points

When posting code, always use Markdown formatting to preserve the code's appearance and retain special symbols (such as the ` accent mark).

But shorter isn't always "better". There's a value in having code that's easily readable, and over-optimizing and abbreviating can compromise that. This sample seems pretty concise as is, not much could be reduced and still have it easy to read.