anything wrong with this js code?

Question

here is my snapshot:https://w.trhou.se/3nsbahv8qt

i tried to make it so that if the order number is a certain number it'd display a stage of the form. it works but after i click the previous button the margin of the next button gets messed up.

//make the variables for stuff for convenience
const nextbutton = document.body.querySelector(".next");
const previousbutton = document.body.querySelector(".previous");
const progressbarjuice = document.body.querySelector(".bar .myval");
const inputname = document.body.querySelector("#nameinput");
const emailinput = document.body.querySelector("#emailinput");
const inputphonenumber = document.body.querySelector('#inputphonenumber')
const percentincrement = 33.333;
let ordernumber=1;
let placeholder='';
function condition(){
    if (ordernumber===1){
        placeholder=inputname;
    }else if(ordernumber===2){
        placeholder=emailinput;
        otherplaceholder=inputname;
    }else if(ordernumber===3){
        placeholder=inputphonenumber;
        otherplaceholder=emailinput;
    }
}

nextbutton.addEventListener(
  "click", ()=>{
    ordernumber+=1;
    condition();
    progressbarjuice.style.width += `${percentincrement}%`;
    otherplaceholder.style.display="none";
    placeholder.style.display="block";
  }
)

previousbutton.addEventListener(
  "click", ()=>{
    condition();
    ordernumber-=1;
    otherplaceholder.style.display="block";
    placeholder.style.display="none";
  }
)

here is the code

Answer 1 · 2024-09-09T14:21:47Z

September 9, 2024 2:21pm

The button margins don't change, but the width of the flex form div does. This shifts the button position.

I notice there is quite a bit of redundancy in the page layout. This is a great opportunity to practice the DRY principle ("Don't Repeat Yourself"). For example, having just one control that you adjust properties on (compared to multiple copies that become visible and invisible) could allow for code that would be much less likely to exhibit mystery behaviors such as this.

You might benefit by setting this project aside for a while and taking a few more of the courses. I know some of them teach DRY design, DOM manipulation, and various methods of styling and layout which would all assist your project development.

Welcome to the Treehouse Community

Looking to learn something new?

jason limmm

jason limmm

anything wrong with this js code?

1 Answer

Steven Parker

Steven Parker

jason limmm

jason limmm

Steven Parker

Steven Parker