Welcome to the Treehouse Community

The Treehouse Community is a meeting place for developers, designers, and programmers of all backgrounds and skill levels to get support. Collaborate here on code errors or bugs that you need feedback on, or asking for an extra set of eyes on your latest project. Join thousands of Treehouse students and alumni in the community today. (Note: Only Treehouse students can comment or ask questions, but non-students are welcome to browse our conversations.)

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and a supportive community. Start your free trial today.

JavaScript JavaScript Accordion

josephweiss2
josephweiss2
5,828 Points

Better solution!

In the JavaScript code after passing forEach it would be even better if we put in an IF statement, like this only if you press on the header that has the + or - on it the content gets hidden or active and not if you press it everywhere on the .accordion div. I have included here my if statement: Look much nicer in my opinion!

const accordions = document.querySelectorAll('.accordion');
accordions.forEach(accordion => {
  accordion.addEventListener('click', e => {

    if (e.target.classList.contains('accordion-header') || e.target.nodeName=='BUTTON') {

      let accordionBtn = accordion.querySelector('button');
      accordion.classList.toggle('active');
      if (accordionBtn.textContent=== '+') {
        accordionBtn.textContent= '-'
      } else {
        accordionBtn.textContent= '+'
      }

    }

  })
});