Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python Django Authentication Users and Authorization Add to Group

Bummer: Try again

Update the create_editor method in the UserManager so that, when an editor is created, they're automatically added to a group named "Editors".

The "Editors" group may not exist and might not have the can_give_discount permission, so make sure to handle those scenarios.

not sure what I'm doing wrong, please help

accounts/models.py
from django.contrib.auth.models import (
    PermissionsMixin,
    BaseUserManager,
    AbstractBaseUser,
    Permission,
    Group
)
from django.db import models
from django.utils import timezone


class UserManager(BaseUserManager):
    def create_user(self, email, dob, accepted_tos=None, password=None):
        if not accepted_tos:
            raise ValueError("Users must accept the terms of service")

        user = self.model(
            email=self.normalize_email(email),
            dob=dob,
            accepted_tos=True
        )
        user.set_password(password)
        user.save()
        return user

    def create_superuser(self, email, dob, password):
        user = self.create_user(
            email,
            dob,
            accepted_tos=True,
            password=password
        )
        user.is_staff = True
        user.is_superuser = True
        user.save()
        return user

    def create_editor(self, email, dob, password):
        user = self.create_user(
            email,
            dob,
            accepted_tos=True,
            password=password
        )
        try:
            editors = Group.objects.get(name__iexact="Editors")
        except Group.DoesNotExist:
            editors = Group.objects.create(name="Editors")
            editors.permissions.add(
            Permissions.objects.get(codename="can_give_discount")
        )
        If role in [2,3]:
            editors.permissions.groups.user.add(editors)
        else:
            editors.permissions.groups.user.remove(editors)

        editors.success(request, "@{} is now {}".format(  
            editors.user.user_permissions,
            editors.get_role_display()
        ))

        return super().get(request, *args, **kwargs)


class User(AbstractBaseUser, PermissionsMixin):
    email = models.EmailField(unique=True)
    dob = models.DateField()
    accepted_tos = models.BooleanField()
    is_staff = models.BooleanField(default=False)
    joined_at = models.DateTimeField(default=timezone.now)

    objects = UserManager()

    USERNAME_FIELD = "email"
    REQUIRED_FIELDS = ["dob"]

4 Answers

Bronson Avila
Bronson Avila
4,160 Points

For anyone else who needs help with this challenge, this is what worked for me. Note that you only need to modify the create_editor method, and nothing else.

    def create_editor(self, email, dob, password):
        user = self.create_user(
            email,
            dob,
            accepted_tos=True,
            password=password
        )

        try:
            editors = Group.objects.get(name__iexact='Editors')
        except Group.DoesNotExist:
            editors = Group.objects.create(name='Editors')
            editors.permissions.add(
                Permission.objects.get(codename='can_give_discount')
            )

        user.groups.add(editors)

        return user

I solved it thanks guys

hi, how did you solve this?

Erik Burmeister
seal-mask
.a{fill-rule:evenodd;}techdegree seal-36
Erik Burmeister
Python Web Development Techdegree Graduate 17,108 Points

Christopher Gomez, Chris Freeman. Hello, I was wondering if either of you could help me understand how to pass this challenge. I've tried copying the code from the video, Christopher's version, and a few other varieties. I'm at a loss at this point. I'm not really sure what small detail I need to pass. I would appreciate the help a ton. Thank you!