Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript Object-Oriented JavaScript Getters and Setters Creating Setter Methods

Bummer: Your setter method is returning the wrong value for the major property.

creating_setters.js
class Student {
    constructor(gpa, credits){
        this.gpa = gpa;
        this.credits = credits;
    }

    stringGPA() {
        return this.gpa.toString();
    }

  get major(){
    return this._major;
  }

  set major(major){
    this._major = major;
    if(this._major ==='Junior' || this._major === 'Senior'){
        this._major = major;
    }else {
      this._major = 'None';
    }
  }

    get level() {
        if (this.credits > 90 ) {
            return 'Senior';
        } else if (this.credits > 60) {
            return 'Junior';
        } else if (this.credits > 30) {
            return 'Sophomore';
        } else {
            return 'Freshman';
        }
    }
}

var student = new Student(3.9, 60);

1 Answer

Cameron Childres
Cameron Childres
11,817 Points

Hi Almekdad,

You're almost there. The conditional in your setter method's if statement is checking for 'Junior' and 'Senior' in this._major, but those values are stored in this.level - try checking against this.level instead.

Cameron Childres thank you very much. I completely forgot about this.