Welcome to the Treehouse Community

The Treehouse Community is a meeting place for developers, designers, and programmers of all backgrounds and skill levels to get support. Collaborate here on code errors or bugs that you need feedback on, or asking for an extra set of eyes on your latest project. Join thousands of Treehouse students and alumni in the community today. (Note: Only Treehouse students can comment or ask questions, but non-students are welcome to browse our conversations.)

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and a supportive community. Start your free trial today.

JavaScript Object-Oriented JavaScript Getters and Setters Creating Setter Methods

Devin Ramirez
seal-mask
.a{fill-rule:evenodd;}techdegree
Devin Ramirez
Full Stack JavaScript Techdegree Student 10,790 Points

Bummer: Your setter method is returning the wrong value for the major property.

Guide me in the right direction. What am I missing? Video is unhelpful.

creating_setters.js
class Student {
    constructor(gpa, credits){
        this.gpa = gpa;
        this.credits = credits;
    }

    stringGPA() {
        return this.gpa.toString();
    }

    get level() {
        if (this.credits > 90 ) {
            return 'Senior';
        } else if (this.credits > 60) {
            return 'Junior';
        } else if (this.credits > 30) {
            return 'Sophomore';
        } else {
            return 'Freshman';
        }
    }


  set major(major) {
    if (this.level === 'Senior' || 'Junior') {
      this._major = major;
    } else if (this.level === 'Sophomore' || 'Freshman') {
      this._major = 'None';
    }
  }
}

var student = new Student(3.9, 60);

1 Answer

Jason Anders
MOD
Jason Anders
Treehouse Moderator 145,547 Points

Hi Devin Ramirez

You are on the right track, with just one error (and it is a very common error early on in code learning).

When using a comparative like OR (||) in a conditional statement, you need to specify each check to what is being checked specifically and directly.
Unlike spoken English, you can't just say "I want the apple that is red OR blue." In code, you would need to say "I want the apple that is red OR the apple that is blue." Notice how "apple" is repeated.

So in this exercise, you are comparing each thing to this.level. So instead of

this.level === 'Senior' || 'Junior'

you would need to do

this.level === 'Senior' || this.level === 'Junior'

Nice work.

:) :dizzy: