Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python Object-Oriented Python Dice Roller RPG Roller

Calling a class

I'm not sure how to call the D20 value in the classmethod. Is the rest of my code alright?

dice.py
import random


class Die:
    def __init__(self, sides=2):
        if sides < 2:
            raise ValueError("Can't have fewer than two sides")
        self.sides = sides
        self.value = random.randint(1, sides)

    def __int__(self):
        return self.value

    def __add__(self, other):
        return int(self) + other

    def __radd__(self, other):
        return self + other


class D20(Die):
    def __init__(self):
        super().__init__(sides = 20)
hands.py
#In the hands.py file import the D20 class from dice.py.
from dice import D20

class Hand(list):
    @property
    def total(self):
        return sum(self)

#Create a classmethod named roll
    @classmethod 
    def roll(cls, num_dice):
        dice_list = []
        for x in range(num_dice):
            dice_list = dice_list.append(D20)
            return dice_list
        return cls(dice_list)

1 Answer

Steven Parker
Steven Parker
229,732 Points

It may look like "calling" a function, but with a class it's "instantiating" or "creating a new instance".

Like calling a function, you add parentheses after the name; and you don't want an assignment here:

            dice_list.append(D20())

Also, you won't want that "return" inside the loop. Just keep the one after the loop.

It worked, thank you for the help