Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript and the DOM (Retiring) Getting a Handle on the DOM Selecting Multiple Elements

Vijayalaxmi vastrad
Vijayalaxmi vastrad
2,789 Points
Posted by Vijayalaxmi vastrad
Vijayalaxmi vastrad
2,789 Points

can anyone tell me what is wrong in my code

can anyone tell what is wrong in my code

js/app.js 
var listItems;
var colors = ["#C2272D", "#F8931F", "#FFFF01", "#009245", "#0193D9", "#0C04ED", "#612F90"];

for(var i = 0; i < colors.length; i ++) {
  listItems[i].style.color = colors[i];    
}
index.html 
<!DOCTYPE html>
<html>
  <head>
    <title>Rainbow!</title>
  </head>
  <body>
    <ul id="rainbow">
      <li>This should be red</li>
      <li>This should be orange</li>
      <li>This should be yellow</li>
      <li>This should be green</li>
      <li>This should be blue</li>
      <li>This should be indigo</li>
      <li>This should be violet</li>
    </ul>
    <script src="js/app.js"></script>
  </body>
</html>

2 Answers

<noob />
<noob />
17,062 Points
<noob />
<noob />
17,062 Points

You need to catch the li element inside the up element. You can do it in a lot of ways : catching the ul, then use .children to get all the children of the ul which are the li elements. document.querySelector("#rainbow").children;

you can also do document.querySelectorAll(“li”);

document.getElementsByTagName(“li”);